diff --git a/static/app/views/insights/cache/views/cacheLandingPage.tsx b/static/app/views/insights/cache/views/cacheLandingPage.tsx index 366af93e0aec42..fd2ada7568f9e3 100644 --- a/static/app/views/insights/cache/views/cacheLandingPage.tsx +++ b/static/app/views/insights/cache/views/cacheLandingPage.tsx @@ -205,7 +205,20 @@ export function CacheLandingPage() { )} - {isInDomainView && } + {isInDomainView && ( + + {MODULE_TITLE} + + + } + module={ModuleName.CACHE} + /> + )} diff --git a/static/app/views/insights/database/views/databaseLandingPage.tsx b/static/app/views/insights/database/views/databaseLandingPage.tsx index 1cb6dba3b94ec0..130639a2c4216e 100644 --- a/static/app/views/insights/database/views/databaseLandingPage.tsx +++ b/static/app/views/insights/database/views/databaseLandingPage.tsx @@ -186,7 +186,20 @@ export function DatabaseLandingPage() { )} - {isInDomainView && } + {isInDomainView && ( + + {MODULE_TITLE} + + + } + module={ModuleName.DB} + /> + )} diff --git a/static/app/views/insights/database/views/databaseSpanSummaryPage.tsx b/static/app/views/insights/database/views/databaseSpanSummaryPage.tsx index 48911dd0bc6e4d..8a07f9f7e7d845 100644 --- a/static/app/views/insights/database/views/databaseSpanSummaryPage.tsx +++ b/static/app/views/insights/database/views/databaseSpanSummaryPage.tsx @@ -193,7 +193,7 @@ export function DatabaseSpanSummaryPage({params}: Props) { crumbs={[ ...crumbs, { - label: 'Query Summary', + label: t('Query Summary'), }, ]} /> @@ -207,7 +207,17 @@ export function DatabaseSpanSummaryPage({params}: Props) { )} - {isInDomainView && } + {isInDomainView && ( + + )} diff --git a/static/app/views/insights/http/views/httpDomainSummaryPage.tsx b/static/app/views/insights/http/views/httpDomainSummaryPage.tsx index e9686b83b48b56..0ec3625062f1d1 100644 --- a/static/app/views/insights/http/views/httpDomainSummaryPage.tsx +++ b/static/app/views/insights/http/views/httpDomainSummaryPage.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import React, {Fragment} from 'react'; import Alert from 'sentry/components/alert'; import ProjectAvatar from 'sentry/components/avatar/projectAvatar'; @@ -187,6 +187,14 @@ export function HTTPDomainSummaryPage() { const crumbs = useModuleBreadcrumbs('http'); + const headerTitle = ( + + {project && } + {domain || NULL_DOMAIN_DESCRIPTION} + + + ); + return ( {!isInDomainView && ( @@ -196,7 +204,7 @@ export function HTTPDomainSummaryPage() { crumbs={[ ...crumbs, { - label: 'Domain Summary', + label: t('Domain Summary'), }, ]} /> @@ -219,7 +227,15 @@ export function HTTPDomainSummaryPage() { )} {isInDomainView && view === BACKEND_LANDING_SUB_PATH && ( - + )} diff --git a/static/app/views/insights/http/views/httpLandingPage.tsx b/static/app/views/insights/http/views/httpLandingPage.tsx index 49764e54599a26..b58829e522e821 100644 --- a/static/app/views/insights/http/views/httpLandingPage.tsx +++ b/static/app/views/insights/http/views/httpLandingPage.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import React, {Fragment} from 'react'; import {Breadcrumbs} from 'sentry/components/breadcrumbs'; import ButtonBar from 'sentry/components/buttonBar'; @@ -164,6 +164,13 @@ export function HTTPLandingPage() { const crumbs = useModuleBreadcrumbs('http'); + const headerTitle = ( + + {MODULE_TITLE} + + + ); + return ( {!isInDomainView && ( @@ -171,13 +178,7 @@ export function HTTPLandingPage() { - - {MODULE_TITLE} - - + {headerTitle} @@ -192,7 +193,7 @@ export function HTTPLandingPage() { )} {isInDomainView && view === BACKEND_LANDING_SUB_PATH && ( - + )} diff --git a/static/app/views/insights/pages/backend/backendOverviewPage.tsx b/static/app/views/insights/pages/backend/backendOverviewPage.tsx index 283ab5b72c6214..0a8cfd6a863578 100644 --- a/static/app/views/insights/pages/backend/backendOverviewPage.tsx +++ b/static/app/views/insights/pages/backend/backendOverviewPage.tsx @@ -28,6 +28,7 @@ import {ToolRibbon} from 'sentry/views/insights/common/components/ribbon'; import {useOnboardingProject} from 'sentry/views/insights/common/queries/useOnboardingProject'; import {ViewTrendsButton} from 'sentry/views/insights/common/viewTrendsButton'; import {BackendHeader} from 'sentry/views/insights/pages/backend/backendPageHeader'; +import {BACKEND_LANDING_TITLE} from 'sentry/views/insights/pages/backend/settings'; import {OVERVIEW_PAGE_TITLE} from 'sentry/views/insights/pages/settings'; import {generateBackendPerformanceEventView} from 'sentry/views/performance/data'; import { @@ -157,7 +158,10 @@ function BackendOverviewPage() { organization={organization} renderDisabled={NoAccess} > - } /> + } + /> diff --git a/static/app/views/insights/pages/backend/backendPageHeader.tsx b/static/app/views/insights/pages/backend/backendPageHeader.tsx index 9c14bd0f3a89e8..1ff51eadc7781f 100644 --- a/static/app/views/insights/pages/backend/backendPageHeader.tsx +++ b/static/app/views/insights/pages/backend/backendPageHeader.tsx @@ -4,17 +4,22 @@ import { BACKEND_LANDING_SUB_PATH, BACKEND_LANDING_TITLE, } from 'sentry/views/insights/pages/backend/settings'; -import {DomainViewHeader} from 'sentry/views/insights/pages/domainViewHeader'; +import { + DomainViewHeader, + type Props as HeaderProps, +} from 'sentry/views/insights/pages/domainViewHeader'; import {DOMAIN_VIEW_BASE_URL} from 'sentry/views/insights/pages/settings'; import {ModuleName} from 'sentry/views/insights/types'; type Props = { - headerActions?: React.ReactNode; - module?: ModuleName; + headerTitle: HeaderProps['headerTitle']; + breadcrumbs?: HeaderProps['additionalBreadCrumbs']; + headerActions?: HeaderProps['additonalHeaderActions']; + module?: HeaderProps['selectedModule']; }; // TODO - add props to append to breadcrumbs and change title -export function BackendHeader({module, headerActions}: Props) { +export function BackendHeader({module, headerActions, headerTitle, breadcrumbs}: Props) { const {slug} = useOrganization(); const backendBaseUrl = normalizeUrl( @@ -26,10 +31,11 @@ export function BackendHeader({module, headerActions}: Props) { ); } diff --git a/static/app/views/insights/queues/views/destinationSummaryPage.tsx b/static/app/views/insights/queues/views/destinationSummaryPage.tsx index 18bd0dbe8454fe..e272e2ebb0a78e 100644 --- a/static/app/views/insights/queues/views/destinationSummaryPage.tsx +++ b/static/app/views/insights/queues/views/destinationSummaryPage.tsx @@ -75,7 +75,17 @@ function DestinationSummaryPage() { )} - {isInDomainView && } + {isInDomainView && ( + + )} diff --git a/static/app/views/insights/queues/views/queuesLandingPage.tsx b/static/app/views/insights/queues/views/queuesLandingPage.tsx index 790c82ffa36915..21902f5c93bf5d 100644 --- a/static/app/views/insights/queues/views/queuesLandingPage.tsx +++ b/static/app/views/insights/queues/views/queuesLandingPage.tsx @@ -107,7 +107,20 @@ function QueuesLandingPage() { )} - {isInDomainView && } + {isInDomainView && ( + + {MODULE_TITLE} + + + } + module={ModuleName.QUEUE} + /> + )}