feat(insights): create screen rendering module #79192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 27.54kB (0.09%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79192 +/- ##
==========================================
- Coverage 78.27% 78.27% -0.01%
==========================================
Files 7137 7141 +4
Lines 314561 314596 +35
Branches 51359 51361 +2
==========================================
+ Hits 246232 246248 +16
- Misses 61883 61902 +19
Partials 6446 6446 |
mjq
approved these changes
Oct 18, 2024
Member
mjq
left a comment
mjq
left a comment
There was a problem hiding this comment.
Minor text suggestion is all I've got, LGTM!
static/app/views/insights/common/components/modulesOnboarding.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Quinn <matt.quinn@sentry.io>
harshithadurai
pushed a commit
that referenced
this pull request
Oct 19, 2024
This PR adds a screen rendering module under the domain view. <img width="1258" alt="image" src="https://github.com/user-attachments/assets/03ee8ea1-4df5-486e-b99d-a8bf7b074458"> This is a temporary change, the mobile screen module will require more work, but we can extract the screen rendering section of it as its own module in the meantime. --------- Co-authored-by: Matt Quinn <matt.quinn@sentry.io>
jan-auer
added a commit
that referenced
this pull request
Oct 21, 2024
* master: (288 commits) feat(metrics): Register MRI for spans/count_per_root_project (#78992) feat(dynamic-sampling): Settings for sample rate (#79341) Revert "feat(sentry-sdk): Enable HTTP2 transport" (#79391) fix(feedback): keep oldest date_added for duplicate user reports (#79387) chore(issue-stream): Remove tooltip for Unhandled (#79385) chore(autofix): Show banner if gen AI consent is given, even if no feature flag (#79362) chore(autofix+copilot) Allow autofix without FF if gen AI consent given (#79361) Fixes VULN-50 by enforcing option (#79384) perf(issues): improve adjacent_events query (#79365) feat(issues): Add anchor links back to issue sections (#79333) fix(issue-views): Make tab bar take up entire row (#79383) chore(issues): Add additional metrics for ownership matching (#79302) feat(insights): create screen rendering module (#79192) fix(issues): Avoid streamline issue layout rerenders (#79327) ref(performance): Add missing types to performance widgets (#79301) chore(issue-views): Add translation wrapper to aria label (#79320) chore(issue-stream): Reduce font size of title and message (#79378) feat(insights): update headers and breadcrumbs on frontend domain view (#78945) feat(insights): add view trends button to ai overview (#78611) ref(rr6): Remove unused param (#79379) ...
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
This PR adds a screen rendering module under the domain view. <img width="1258" alt="image" src="https://github.com/user-attachments/assets/03ee8ea1-4df5-486e-b99d-a8bf7b074458"> This is a temporary change, the mobile screen module will require more work, but we can extract the screen rendering section of it as its own module in the meantime. --------- Co-authored-by: Matt Quinn <matt.quinn@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for #77572
This PR adds a screen rendering module under the domain view.
This is a temporary change, the mobile screen module will require more work, but we can extract the screen rendering section of it as its own module in the meantime.