feat(issues): Add anchor links back to issue sections #79333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
commented
Oct 18, 2024
| to={{ | ||
| ...location, | ||
| hash: `#${config.key}`, | ||
| replace: true, |
Member
Author
There was a problem hiding this comment.
is replace the right choice
Member
There was a problem hiding this comment.
I don't mind it, but I don't think the other one replaced did it?
leeandher
approved these changes
Oct 18, 2024
leeandher
reviewed
Oct 18, 2024
Member
leeandher
left a comment
leeandher
left a comment
There was a problem hiding this comment.
I'm not really sure how you can go about testing this. I guess just see if hash gets added, but the scroll logic might be harder
| to={{ | ||
| ...location, | ||
| hash: `#${config.key}`, | ||
| replace: true, |
Member
There was a problem hiding this comment.
I don't mind it, but I don't think the other one replaced did it?
harshithadurai
pushed a commit
that referenced
this pull request
Oct 19, 2024
jan-auer
added a commit
that referenced
this pull request
Oct 21, 2024
* master: (288 commits) feat(metrics): Register MRI for spans/count_per_root_project (#78992) feat(dynamic-sampling): Settings for sample rate (#79341) Revert "feat(sentry-sdk): Enable HTTP2 transport" (#79391) fix(feedback): keep oldest date_added for duplicate user reports (#79387) chore(issue-stream): Remove tooltip for Unhandled (#79385) chore(autofix): Show banner if gen AI consent is given, even if no feature flag (#79362) chore(autofix+copilot) Allow autofix without FF if gen AI consent given (#79361) Fixes VULN-50 by enforcing option (#79384) perf(issues): improve adjacent_events query (#79365) feat(issues): Add anchor links back to issue sections (#79333) fix(issue-views): Make tab bar take up entire row (#79383) chore(issues): Add additional metrics for ownership matching (#79302) feat(insights): create screen rendering module (#79192) fix(issues): Avoid streamline issue layout rerenders (#79327) ref(performance): Add missing types to performance widgets (#79301) chore(issue-views): Add translation wrapper to aria label (#79320) chore(issue-stream): Reduce font size of title and message (#79378) feat(insights): update headers and breadcrumbs on frontend domain view (#78945) feat(insights): add view trends button to ai overview (#78611) ref(rr6): Remove unused param (#79379) ...
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clicking the link should add #tags to the url
refreshing the page or visiting the url should focus that component