From 652821e9584c390c2cb12ffc39171e0019e667c7 Mon Sep 17 00:00:00 2001 From: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com> Date: Wed, 6 Nov 2024 15:52:04 -0800 Subject: [PATCH] ref(replay/feedback): don't suggest empty tag --- static/app/components/feedback/feedbackSearch.tsx | 5 ++++- static/app/views/replays/list/replaySearchBar.tsx | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/static/app/components/feedback/feedbackSearch.tsx b/static/app/components/feedback/feedbackSearch.tsx index 52e55f48d702f1..1e1fcc63a95783 100644 --- a/static/app/components/feedback/feedbackSearch.tsx +++ b/static/app/components/feedback/feedbackSearch.tsx @@ -177,7 +177,10 @@ export default function FeedbackSearch() { projectIds: projectIds?.map(String), endpointParams, }).then( - tagValues => (tagValues as TagValue[]).map(({value}) => value), + tagValues => + (tagValues as TagValue[]) + .filter(tagValue => tagValue.name !== '') + .map(({value}) => value), () => { throw new Error('Unable to fetch event field values'); } diff --git a/static/app/views/replays/list/replaySearchBar.tsx b/static/app/views/replays/list/replaySearchBar.tsx index 6d1a3c866eebd4..9289aebcaa10a8 100644 --- a/static/app/views/replays/list/replaySearchBar.tsx +++ b/static/app/views/replays/list/replaySearchBar.tsx @@ -168,7 +168,10 @@ function ReplaySearchBar(props: Props) { endpointParams, includeReplays: true, }).then( - tagValues => (tagValues as TagValue[]).map(({value}) => value), + tagValues => + (tagValues as TagValue[]) + .filter(tagValue => tagValue.name !== '') + .map(({value}) => value), () => { throw new Error('Unable to fetch event field values'); }