ci(eslint): Inline all the external eslint-config-sentry* ESLint configs into our .eslintrc file #80970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lintrc.js I did skip the `no-restricted-imports` rule, because its just a proxy to eslint-config-sentry/index.js
…quired eslint packages Notice that: - Cleaned up a duplicate `argsIgnorePattern` in the original - `eslint-plugin-jest` went from resolved version `28.8.3` to `28.9.0` -> https://github.com/jest-community/eslint-plugin-jest/releases/tag/v28.9.0 - `eslint-plugin-react` went from resolved version `7.37.1` to `7.37.2` - We're getting some new resolutions in the yarn.lock file
note that we still have `settings.react.version: 17.0.2`. It was wrong before but i'm leaving it. Enabling it will cause passwordStrength.tsx to error with `ReactDOM.render is deprecated`
Note that previously `no-else-return` was defined twice.
Once as:
```
'no-else-return': ['off'],
```
and again as:
```
'no-else-return': ['error', {allowElseIf: false}],
```
The latter remains
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80970 +/- ##
========================================
Coverage 78.49% 78.49%
========================================
Files 7210 7216 +6
Lines 319520 319772 +252
Branches 43983 44030 +47
========================================
+ Hits 250796 250995 +199
- Misses 62332 62388 +56
+ Partials 6392 6389 -3 |
scttcper
reviewed
Nov 19, 2024
Comment on lines
+190
to
+191
| // https://eslint.org/docs/rules/space-in-brackets.html | ||
| 'object-curly-spacing': ['error', 'never'], |
Member
There was a problem hiding this comment.
would be nice to follow up by removing any of the rules that are now in @stylistic/eslint-plugin-js since they are overwritten or disabled by prettier anyway
they should all have the deprecation notice in their docs https://eslint.org/docs/latest/rules/object-curly-spacing
Member
Author
There was a problem hiding this comment.
there's so much to cleanup. I didn't even touch the react version: '17.0.2' bit yet :(
scttcper
reviewed
Nov 19, 2024
package.json
Outdated
| "benchmark": "^2.1.4", | ||
| "eslint": "8.57.1", | ||
| "eslint-config-sentry-app": "2.9.0", | ||
| "eslint-config-sentry": "^2.10.0", |
Member
Author
There was a problem hiding this comment.
yup! the last step.
we do still need the plugin though, just not this config.
…the plugin package however
scttcper
approved these changes
Nov 20, 2024
scttcper
reviewed
Nov 20, 2024
.eslintrc.js
Outdated
| }; | ||
|
|
||
| const extendsList = [ | ||
| 'sentry', |
Member
There was a problem hiding this comment.
i think its complaining about this
Bundle ReportChanges will increase total bundle size by 37.81kB (0.12%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
iamrajjoshi
pushed a commit
that referenced
this pull request
Nov 24, 2024
…igs into our .eslintrc file (#80970) Related to https://github.com/getsentry/frontend-tsc/issues/81 I'm proposing that we inline all this eslint config into the repo, instead of leveraging an external package. The idea is to make it easier and faster to iterate on. This PR is just an naive 7 mechanical operation: inline everything and don't refactor too much. Each commit in this PR should be easy to compare against https://github.com/getsentry/eslint-config-sentry with some small things to note along the way. The followup task will be https://github.com/getsentry/frontend-tsc/issues/82 which is a good time to squash objects and generally have a reason to refactor what's in here. Possible strategies might be to stratify the config values based on some/all of: - plugin name - runtime speed ie: `import slowRules from './eslint/slowRules.js';` - etc.
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
…igs into our .eslintrc file (#80970) Related to getsentry/frontend-tsc#81 I'm proposing that we inline all this eslint config into the repo, instead of leveraging an external package. The idea is to make it easier and faster to iterate on. This PR is just an naive 7 mechanical operation: inline everything and don't refactor too much. Each commit in this PR should be easy to compare against https://github.com/getsentry/eslint-config-sentry with some small things to note along the way. The followup task will be getsentry/frontend-tsc#82 which is a good time to squash objects and generally have a reason to refactor what's in here. Possible strategies might be to stratify the config values based on some/all of: - plugin name - runtime speed ie: `import slowRules from './eslint/slowRules.js';` - etc.
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
…igs into our .eslintrc file (#80970) Related to getsentry/frontend-tsc#81 I'm proposing that we inline all this eslint config into the repo, instead of leveraging an external package. The idea is to make it easier and faster to iterate on. This PR is just an naive 7 mechanical operation: inline everything and don't refactor too much. Each commit in this PR should be easy to compare against https://github.com/getsentry/eslint-config-sentry with some small things to note along the way. The followup task will be getsentry/frontend-tsc#82 which is a good time to squash objects and generally have a reason to refactor what's in here. Possible strategies might be to stratify the config values based on some/all of: - plugin name - runtime speed ie: `import slowRules from './eslint/slowRules.js';` - etc.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
…igs into our .eslintrc file (#80970) Related to getsentry/frontend-tsc#81 I'm proposing that we inline all this eslint config into the repo, instead of leveraging an external package. The idea is to make it easier and faster to iterate on. This PR is just an naive 7 mechanical operation: inline everything and don't refactor too much. Each commit in this PR should be easy to compare against https://github.com/getsentry/eslint-config-sentry with some small things to note along the way. The followup task will be getsentry/frontend-tsc#82 which is a good time to squash objects and generally have a reason to refactor what's in here. Possible strategies might be to stratify the config values based on some/all of: - plugin name - runtime speed ie: `import slowRules from './eslint/slowRules.js';` - etc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/getsentry/frontend-tsc/issues/81
I'm proposing that we inline all this eslint config into the repo, instead of leveraging an external package. The idea is to make it easier and faster to iterate on.
This PR is just an naive 7 mechanical operation: inline everything and don't refactor too much. Each commit in this PR should be easy to compare against https://github.com/getsentry/eslint-config-sentry with some small things to note along the way.
The followup task will be https://github.com/getsentry/frontend-tsc/issues/82 which is a good time to squash objects and generally have a reason to refactor what's in here. Possible strategies might be to stratify the config values based on some/all of:
import slowRules from './eslint/slowRules.js';