Skip to content

feat(ui): Support customizing help tooltip in FieldGroup #81136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat(ui): Support customizing help tooltip in FieldGroup #81136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion static/app/components/forms/fieldGroup/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,12 @@ function FieldGroup({
</span>
{helpElement && showHelpInTooltip && (
<FieldQuestion>
<QuestionTooltip position="top" size="sm" title={helpElement} />
<QuestionTooltip
position="top"
size="sm"
{...(showHelpInTooltip !== true ? showHelpInTooltip : {})}
title={helpElement}
/>
</FieldQuestion>
)}
</FieldLabel>
Expand Down
7 changes: 5 additions & 2 deletions static/app/components/forms/fieldGroup/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import type {TooltipProps} from 'sentry/components/tooltip';

/**
* Props that control UI elements that are part of a Form Group
*/
Expand Down Expand Up @@ -91,9 +93,10 @@ export interface FieldGroupProps {
*/
required?: boolean;
/**
* Displays the help element in the tooltip
* Displays the help element in the tooltip. Tooltip props may be passed to
* customize the help tooltip.
*/
showHelpInTooltip?: boolean;
showHelpInTooltip?: boolean | Omit<TooltipProps, 'title'>;
/**
* When stacking forms the bottom border is hidden and padding is adjusted
* for form elements to be stacked on each other.
Expand Down
Loading