feat(explore): Ensure id column is present in samples mode #81195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for users to remove the id column in the column editor. But if they do so, the result isn't very useful since it won't link to a trace. So we ensure the id column is always present no matter what columns are selected.
github-actions
bot
added
the
Scope: Frontend
wmak
approved these changes
Nov 22, 2024
Zylphrex
deleted the
txiao/feat/ensure-id-column-is-present-in-samples-mode
branch
harshithadurai
pushed a commit
that referenced
this pull request
Nov 25, 2024
It's possible for users to remove the id column in the column editor. But if they do so, the result isn't very useful since it won't link to a trace. So we ensure the id column is always present no matter what columns are selected.
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
It's possible for users to remove the id column in the column editor. But if they do so, the result isn't very useful since it won't link to a trace. So we ensure the id column is always present no matter what columns are selected.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
It's possible for users to remove the id column in the column editor. But if they do so, the result isn't very useful since it won't link to a trace. So we ensure the id column is always present no matter what columns are selected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for users to remove the id column in the column editor. But if they do so, the result isn't very useful since it won't link to a trace. So we ensure the id column is always present no matter what columns are selected.