Skip to content

Conversation

@Zylphrex
Copy link
Member

We can consolidate the continuous-profiling-ui and continuous-profiling-compat flags now as they will be enabled for all orgs.

We can consolidate the continuous-profiling-ui and continuous-profiling-compat
flags now as they will be enabled for all orgs.
@Zylphrex Zylphrex requested a review from a team as a code owner November 25, 2024 19:32
@Zylphrex Zylphrex requested a review from a team November 25, 2024 19:32
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2024
@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nce/newTraceDetails/traceDrawer/details/styles.tsx 0.00% 4 Missing ⚠️
...ic/app/components/profiling/profileEventsTable.tsx 33.33% 2 Missing ⚠️
...e/transactionSummary/transactionProfiles/index.tsx 0.00% 1 Missing ⚠️
static/app/views/profiling/content.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #81260       +/-   ##
===========================================
+ Coverage   58.81%   80.36%   +21.54%     
===========================================
  Files        7208     7231       +23     
  Lines      319210   319586      +376     
  Branches    20772    20810       +38     
===========================================
+ Hits       187737   256820    +69083     
+ Misses     131079    62373    -68706     
+ Partials      394      393        -1     

@codecov
Copy link

codecov bot commented Nov 27, 2024

Bundle Report

Changes will increase total bundle size by 12.19kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 31.96MB 12.19kB (0.04%) ⬆️

@Zylphrex Zylphrex enabled auto-merge (squash) November 27, 2024 18:59
@Zylphrex Zylphrex merged commit 2613081 into master Nov 27, 2024
43 of 44 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/clean-up-continuous-profiling-ui-and-compat-flags branch November 27, 2024 19:06
jan-auer added a commit that referenced this pull request Nov 28, 2024
* master: (219 commits)
  fix: flatten searchable os distribution fields (#81297)
  chore(profiling): Remvoe unused profile functions metrics hook (#81396)
  fix(prompts): Properly return false instead of undefined when prompt data is null (#81404)
  fix(insights): broken screen rendering doc link (#81257)
  fix(rpc): Only groupby when needed (#81403)
  feat(grouping): Tally frame types while building exception grouping components (#81341)
  fix(similarity): Limit > 30 system frame check to Java (#81385)
  feat(alerts): Adds EAP spans results consumer configs (#81365)
  ref(insights): simplify domain view header by using tab links (#81324)
  fix(issues): Add projectId for flag onboarding on click (#81387)
  chore(flamegraphs): Remove unused legacy flamegraph code path (#81381)
  fix(performance): No table overflow + glitchy behaviour (#81378)
  feat(widget-builder): Add feature flag for redesign (#81377)
  feat(profiling): Clean up continuous profiling ui and compat flags (#81260)
  feat(visibility): Clamp date range for `TagStore` queries (#81363)
  test(taskbroker): Add CLI command for sending taskbroker tasks (#81319)
  feat(dashboards): Add ff for favouriting dashboards (#81368)
  fix(trace) match event_id by error (#81370)
  fix(insights): add missing slash on performance moving banner (#81364)
  ref(models): Include event id in `Event` repr (#81345)
  ...
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
…81260)

We can consolidate the continuous-profiling-ui and
continuous-profiling-compat flags now as they will be enabled for all
orgs.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants