feat(visibility): Clamp date range for TagStore queries
#81363
Merged
+92
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
This comment was marked as outdated.
This comment was marked as outdated.
Zylphrex
approved these changes
Nov 27, 2024
| assert isinstance(e, (FooBarError, APIException)) | ||
|
|
||
|
|
||
| class ClampDateRangeTest(unittest.TestCase): |
Member
There was a problem hiding this comment.
What happens if max_timedelta is set to 0?
Member
Author
There was a problem hiding this comment.
I decided to allow 0 there, since I don't want to throw any exceptions. Added a test!
Co-authored-by: Tony Xiao <txiao@sentry.io>
Co-authored-by: Tony Xiao <txiao@sentry.io>
Member
Author
|
@Zylphrex took your suggestions, thanks! |
jan-auer
added a commit
that referenced
this pull request
Nov 28, 2024
* master: (219 commits) fix: flatten searchable os distribution fields (#81297) chore(profiling): Remvoe unused profile functions metrics hook (#81396) fix(prompts): Properly return false instead of undefined when prompt data is null (#81404) fix(insights): broken screen rendering doc link (#81257) fix(rpc): Only groupby when needed (#81403) feat(grouping): Tally frame types while building exception grouping components (#81341) fix(similarity): Limit > 30 system frame check to Java (#81385) feat(alerts): Adds EAP spans results consumer configs (#81365) ref(insights): simplify domain view header by using tab links (#81324) fix(issues): Add projectId for flag onboarding on click (#81387) chore(flamegraphs): Remove unused legacy flamegraph code path (#81381) fix(performance): No table overflow + glitchy behaviour (#81378) feat(widget-builder): Add feature flag for redesign (#81377) feat(profiling): Clean up continuous profiling ui and compat flags (#81260) feat(visibility): Clamp date range for `TagStore` queries (#81363) test(taskbroker): Add CLI command for sending taskbroker tasks (#81319) feat(dashboards): Add ff for favouriting dashboards (#81368) fix(trace) match event_id by error (#81370) fix(insights): add missing slash on performance moving banner (#81364) ref(models): Include event id in `Event` repr (#81345) ...
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Follow-up and complement to #80332. In short, `SAMPLE` wasn't enough. For longer ranges (i.e., >30d) fetching a list of project tags still times out. In this PR, we're adding time range clamping for fetching tag keys. We will only ever query a maximum of N days (14 for now, but it's configurable). If someone chooses to get tags for the last 90 days, they will get tags from the last 14 days. If they need tags from November 5th - November 10th, we will fetch the range they asked for. We think this is a reasonable compromise. When tags don't load at all, autocomplete stops working, which is very bad UX. Limiting the date range to 14 days is a tradeoff. The tags will succeed more often, but some tags might be missing. Also, limiting the range should improve the cache hit ratio a bit, but we'll see. --------- Co-authored-by: Tony Xiao <txiao@sentry.io> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up and complement to #80332. In short,
SAMPLEwasn't enough. For longer ranges (i.e., >30d) fetching a list of project tags still times out.In this PR, we're adding time range clamping for fetching tag keys. We will only ever query a maximum of N days (14 for now, but it's configurable). If someone chooses to get tags for the last 90 days, they will get tags from the last 14 days. If they need tags from November 5th - November 10th, we will fetch the range they asked for.
We think this is a reasonable compromise. When tags don't load at all, autocomplete stops working, which is very bad UX. Limiting the date range to 14 days is a tradeoff. The tags will succeed more often, but some tags might be missing.
Also, limiting the range should improve the cache hit ratio a bit, but we'll see.