fix(similarity): Limit > 30 system frame check to Java #81385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
jangjodi
commented
Nov 27, 2024
| elif exception_value.get("id") == "stacktrace" and frame_count < MAX_FRAME_COUNT: | ||
| frame_strings = _process_frames(exception_value["values"]) | ||
| if is_frames_truncated and not app_hash: | ||
| if platform in SYSTEM_FRAME_CHECK_PLATFORMS and is_frames_truncated and not app_hash: |
Contributor
Author
There was a problem hiding this comment.
only raise this exception if the platform is in SYSTEM_FRAME_CHECK_PLATFORMS
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81385 +/- ##
=======================================
Coverage 80.37% 80.37%
=======================================
Files 7231 7231
Lines 319927 319928 +1
Branches 20810 20810
=======================================
+ Hits 257156 257158 +2
+ Misses 62378 62377 -1
Partials 393 393 |
jan-auer
added a commit
that referenced
this pull request
Nov 28, 2024
* master: (219 commits) fix: flatten searchable os distribution fields (#81297) chore(profiling): Remvoe unused profile functions metrics hook (#81396) fix(prompts): Properly return false instead of undefined when prompt data is null (#81404) fix(insights): broken screen rendering doc link (#81257) fix(rpc): Only groupby when needed (#81403) feat(grouping): Tally frame types while building exception grouping components (#81341) fix(similarity): Limit > 30 system frame check to Java (#81385) feat(alerts): Adds EAP spans results consumer configs (#81365) ref(insights): simplify domain view header by using tab links (#81324) fix(issues): Add projectId for flag onboarding on click (#81387) chore(flamegraphs): Remove unused legacy flamegraph code path (#81381) fix(performance): No table overflow + glitchy behaviour (#81378) feat(widget-builder): Add feature flag for redesign (#81377) feat(profiling): Clean up continuous profiling ui and compat flags (#81260) feat(visibility): Clamp date range for `TagStore` queries (#81363) test(taskbroker): Add CLI command for sending taskbroker tasks (#81319) feat(dashboards): Add ff for favouriting dashboards (#81368) fix(trace) match event_id by error (#81370) fix(insights): add missing slash on performance moving banner (#81364) ref(models): Include event id in `Event` repr (#81345) ...
armenzg
added a commit
that referenced
this pull request
Dec 2, 2024
In #81385, we whitelisted a list of platforms that would be prevented from sending seer more than 30 system contributing frames. Changing it to a blacklist allows adding new platforms without requirying to opt them in to the new behaviour. Over time, we should move more platforms from the blacklist to the whitelist.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Limit > 30 system frame check to Java platform due to bug in grouping info
armenzg
added a commit
that referenced
this pull request
Dec 3, 2024
… it (#81520) In #81385, we whitelisted a list of platforms that would be prevented from sending seer more than 30 system contributing frames. Changing it to a blacklist allows adding new platforms without requiring them to opt into the new behaviour. Over time, we should move more platforms from the blacklist to the whitelist.
armenzg
added a commit
that referenced
this pull request
Dec 12, 2024
…frames This is a follow-up to #81385. This prevents both *in-app* and *system* frames from being sent to seer when over 30 frames since we can't guarantee that we're not overgrouping.
armenzg
added a commit
that referenced
this pull request
Dec 12, 2024
This is a follow-up to #81385. This prevents both *in-app* and *system* frames from being sent to Seer when we have more than 30 frames since we can't guarantee that we're not overgrouping.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit > 30 system frame check to Java platform due to bug in grouping info