feat(grouping): Blacklist a list of platforms instead of whitelisting it #81520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #81385, we whitelisted a list of platforms that would be prevented from sending seer more than 30 system contributing frames. Changing it to a blacklist allows adding new platforms without requirying to opt them in to the new behaviour. Over time, we should move more platforms from the blacklist to the whitelist.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Dec 2, 2024
| # An original set of platforms were backfilled allowing more than 30 system contributing frames | ||
| # being set to seer. Unfortunately, this can cause over grouping. We will need to reduce | ||
| # these set of platforms but for now we will blacklist them. | ||
| SYSTEM_FRAME_CHECK_BLACKLIST_PLATFORMS = frozenset( |
Member
Author
There was a problem hiding this comment.
This is the original list before I started adding Java platforms.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81520 +/- ##
==========================================
+ Coverage 80.43% 80.47% +0.03%
==========================================
Files 7241 7237 -4
Lines 321569 321261 -308
Branches 20829 20770 -59
==========================================
- Hits 258656 258536 -120
+ Misses 62521 62323 -198
- Partials 392 402 +10 |
jangjodi
approved these changes
Dec 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #81385, we whitelisted a list of platforms that would be prevented from sending seer more than 30 system contributing frames.
Changing it to a blacklist allows adding new platforms without requiring them to opt into the new behaviour.
Over time, we should move more platforms from the blacklist to the whitelist.