feat(similarity): Do not send more than 30 frames to Seer #82009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…frames This is a follow-up to #81385. This prevents both *in-app* and *system* frames from being sent to seer when over 30 frames since we can't guarantee that we're not overgrouping.
armenzg
changed the title
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Dec 12, 2024
Member
Author
There was a problem hiding this comment.
Adding platform=javascript is because we allow sending more than 30 frames for these tests.
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
JoshFerge
approved these changes
Dec 12, 2024
armenzg
deleted the
fix/avoid_more_than_30_frames/similarity/grouping/armenzg
branch
armenzg
added a commit
that referenced
this pull request
Dec 12, 2024
Now that #82009 has been shipped I feel comfortable enabling this platform.
evanh
pushed a commit
that referenced
this pull request
Dec 17, 2024
This is a follow-up to #81385. This prevents both *in-app* and *system* frames from being sent to Seer when we have more than 30 frames since we can't guarantee that we're not overgrouping.
evanh
pushed a commit
that referenced
this pull request
Dec 17, 2024
Now that #82009 has been shipped I feel comfortable enabling this platform.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #81385.
This prevents both in-app and system frames from being sent to Seer when we have more than 30 frames since we can't guarantee that we're not overgrouping.