feat(issue-details): Add tags from highlights to preview + drawer #84278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #84278 +/- ##
==========================================
+ Coverage 81.31% 87.67% +6.35%
==========================================
Files 9611 9575 -36
Lines 543565 541569 -1996
Branches 21330 21204 -126
==========================================
+ Hits 442015 474822 +32807
+ Misses 101196 66395 -34801
+ Partials 354 352 -2 |
scttcper
reviewed
Jan 30, 2025
| const orderedTags = [...sortedTags, ...remainingTagKeys]; | ||
| return orderedTags.slice(0, 4); | ||
| }, [tags, project?.platform]); | ||
| const orderedTags = [...highlightTags, ...sortedTags, ...remainingTagKeys]; |
Member
There was a problem hiding this comment.
i'm not totally in love with this but we can try it
scttcper
reviewed
Jan 30, 2025
| return orderedTags.slice(0, 4); | ||
| }, [tags, project?.platform]); | ||
| const orderedTags = [...highlightTags, ...sortedTags, ...remainingTagKeys]; | ||
| const uniqueTags = [...new Set(orderedTags)]; |
Member
There was a problem hiding this comment.
i forgot that sets were insertion ordered so thanks for that
scttcper
reviewed
Jan 30, 2025
| const MOBILE_TAGS = ['device', 'os', 'release', 'environment', 'transaction']; | ||
| const RTL_TAGS = ['transaction', 'url']; | ||
|
|
||
| const HIGHLIGHT_TAGS = ['handled', 'level', 'mobile', 'main_thread', 'url']; |
Member
There was a problem hiding this comment.
i think the problem i have is here. handled and level are usually not interesting and are also default highlight tags
scttcper
approved these changes
Jan 30, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Feb 5, 2025
…4278) this pr updates the tag preview and drawer to show any tags that are highlighted for a project first. for the preview, it filters out any default highlights (because we already have a list of tags to show in the preview).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr updates the tag preview and drawer to show any tags that are highlighted for a project first. for the preview, it filters out any default highlights (because we already have a list of tags to show in the preview).