Skip to content

Fix(ui): Fix issue details warnings #8745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maheskett merged 2 commits into from
Jun 15, 2018
Merged

Fix(ui): Fix issue details warnings #8745

maheskett merged 2 commits into from
Jun 15, 2018

Conversation

@maheskett
Copy link
Contributor

@maheskett maheskett commented Jun 14, 2018 •
edited
Loading

  • Warning: Each child in an array or iterator should have a unique "key" prop.
  • Warning: Invalid value for prop title on tag
  • Warning: Render methods should be a pure function of props and state; triggering nested component updates from render is not allowed. If necessary, trigger nested updates in componentDidUpdate.

@maheskett maheskett force-pushed the maheskett/fix-issue-details-warning branch 2 times, most recently from 774a2fc to 2c3f210 Compare June 15, 2018 00:52
@maheskett maheskett requested a review from billyvg June 15, 2018 17:31
billyvg
billyvg reviewed Jun 15, 2018
View reviewed changes
src/sentry/static/sentry/app/utils/componentToString.jsx Outdated
import ReactDOM from 'react-dom';
import ReactDOMServer from 'react-dom/server';

export default function(node) {
Copy link
Member

@billyvg billyvg Jun 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add componentToString as a name for this function (there'll be an eslint rule for this).

src/sentry/static/sentry/app/components/group/seenInfo.jsx Outdated
let {date, dateGlobal, environment, title} = this.props;

return componentToString(
return ReactDOMServer.renderToStaticMarkup(
Copy link
Member

@billyvg billyvg Jun 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep componentToString here since we've updated its definition to use renderToStaticMarkup

src/sentry/static/sentry/app/components/group/seenInfo.jsx
{date ? (
<dd key={1}>
<Tooltip title={this.getTooltipTitle} tooltipOptions={{html: true}}>
<Tooltip title={this.getTooltipTitle()} tooltipOptions={{html: true}}>
Copy link
Member

@billyvg billyvg Jun 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@maheskett maheskett force-pushed the maheskett/fix-issue-details-warning branch from 2c3f210 to 3b3c659 Compare June 15, 2018 18:25
@maheskett maheskett force-pushed the maheskett/fix-issue-details-warning branch from 3b3c659 to 27c3913 Compare June 15, 2018 18:48
@maheskett maheskett merged commit f39e324 into master Jun 15, 2018
@maheskett maheskett deleted the maheskett/fix-issue-details-warning branch June 15, 2018 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@billyvg billyvg billyvg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maheskett @billyvg