Skip to content

Conversation

@armcknight
Copy link
Member

Convert the onboarding instructions for cocoa onboarding profiling options for the new V2 API.

For getsentry/sentry-cocoa#4996

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2025
@armcknight armcknight marked this pull request as ready for review April 1, 2025 23:11
@armcknight armcknight requested a review from a team as a code owner April 1, 2025 23:11
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #88507      +/-   ##
==========================================
- Coverage   87.75%   87.75%   -0.01%     
==========================================
  Files       10012    10012              
  Lines      567214   567046     -168     
  Branches    22295    22295              
==========================================
- Hits       497749   497593     -156     
+ Misses      69048    69036      -12     
  Partials      417      417              

@armcknight
Copy link
Member Author

Thanks @Zylphrex and @ArthurKnaus . will wait to ship the sdk changes before merging this. See getsentry/sentry-cocoa#4952

@kahest kahest merged commit e92ba9a into master Apr 9, 2025
41 checks passed
@kahest kahest deleted the armcknight/profiling/feat/profiling-v2-onboarding branch April 9, 2025 16:50
Christinarlong pushed a commit that referenced this pull request Apr 10, 2025
Convert the onboarding instructions for cocoa onboarding profiling
options for the new V2 API.

For getsentry/sentry-cocoa#4996

---------

Co-authored-by: Tony Xiao <txiao@sentry.io>
Co-authored-by: Arthur Knaus <arthur.knaus@sentry.io>
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
Convert the onboarding instructions for cocoa onboarding profiling
options for the new V2 API.

For getsentry/sentry-cocoa#4996

---------

Co-authored-by: Tony Xiao <txiao@sentry.io>
Co-authored-by: Arthur Knaus <arthur.knaus@sentry.io>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Platform: Cocoa Product Area: Profiling Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants