-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: convert onboarding to continuous profiling v2 #88507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kahest
merged 4 commits into
master
from
armcknight/profiling/feat/profiling-v2-onboarding
Apr 9, 2025
Merged
feat: convert onboarding to continuous profiling v2 #88507
kahest
merged 4 commits into
master
from
armcknight/profiling/feat/profiling-v2-onboarding
Apr 9, 2025
+30
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88507 +/- ##
==========================================
- Coverage 87.75% 87.75% -0.01%
==========================================
Files 10012 10012
Lines 567214 567046 -168
Branches 22295 22295
==========================================
- Hits 497749 497593 -156
+ Misses 69048 69036 -12
Partials 417 417 |
ArthurKnaus
approved these changes
Apr 3, 2025
Member
Author
|
Thanks @Zylphrex and @ArthurKnaus . will wait to ship the sdk changes before merging this. See getsentry/sentry-cocoa#4952 |
Christinarlong
pushed a commit
that referenced
this pull request
Apr 10, 2025
Convert the onboarding instructions for cocoa onboarding profiling options for the new V2 API. For getsentry/sentry-cocoa#4996 --------- Co-authored-by: Tony Xiao <txiao@sentry.io> Co-authored-by: Arthur Knaus <arthur.knaus@sentry.io>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
Convert the onboarding instructions for cocoa onboarding profiling options for the new V2 API. For getsentry/sentry-cocoa#4996 --------- Co-authored-by: Tony Xiao <txiao@sentry.io> Co-authored-by: Arthur Knaus <arthur.knaus@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Platform: Cocoa
Product Area: Profiling
Scope: Frontend
Automatically applied to PRs that change frontend components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the onboarding instructions for cocoa onboarding profiling options for the new V2 API.
For getsentry/sentry-cocoa#4996