diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt index 399915e968d347..5d05b88b9c58f4 100644 --- a/migrations_lockfile.txt +++ b/migrations_lockfile.txt @@ -17,7 +17,7 @@ remote_subscriptions: 0003_drop_remote_subscription replays: 0004_index_together -sentry: 0860_add_new_groupopenperiod_constraint +sentry: 0861_monitors_remove_location social_auth: 0002_default_auto_field diff --git a/src/sentry/db/router.py b/src/sentry/db/router.py index a13ec0d7c69072..cd3ee4a3e3c835 100644 --- a/src/sentry/db/router.py +++ b/src/sentry/db/router.py @@ -74,6 +74,7 @@ class SiloRouter: "authprovider_duplicate": SiloMode.CONTROL, "authidentity_duplicate": SiloMode.CONTROL, "sentry_alertruleactivations": SiloMode.REGION, + "sentry_monitorlocation": SiloMode.REGION, } """ When we remove models, we are no longer able to resolve silo assignments @@ -218,9 +219,9 @@ class TestSiloMultiDatabaseRouter(SiloRouter): secondary_db_models = { "sentry_monitor", "sentry_monitorcheckin", - "sentry_monitorlocation", "sentry_monitorenvironment", "sentry_monitorincident", + "sentry_monitorlocation", "sentry_monitorenvbrokendetection", } diff --git a/src/sentry/migrations/0861_monitors_remove_location.py b/src/sentry/migrations/0861_monitors_remove_location.py new file mode 100644 index 00000000000000..16caf68e49817c --- /dev/null +++ b/src/sentry/migrations/0861_monitors_remove_location.py @@ -0,0 +1,29 @@ +# Generated by Django 5.1.7 on 2025-04-01 20:43 + +from sentry.new_migrations.migrations import CheckedMigration +from sentry.new_migrations.monkey.models import SafeDeleteModel +from sentry.new_migrations.monkey.state import DeletionAction + + +class Migration(CheckedMigration): + # This flag is used to mark that a migration shouldn't be automatically run in production. + # This should only be used for operations where it's safe to run the migration after your + # code has deployed. So this should not be used for most operations that alter the schema + # of a table. + # Here are some things that make sense to mark as post deployment: + # - Large data migrations. Typically we want these to be run manually so that they can be + # monitored and not block the deploy for a long period of time while they run. + # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to + # run this outside deployments so that we don't block them. Note that while adding an index + # is a schema change, it's completely safe to run the operation after the code has deployed. + # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment + + is_post_deployment = False + + dependencies = [ + ("sentry", "0860_add_new_groupopenperiod_constraint"), + ] + + operations = [ + SafeDeleteModel(name="MonitorLocation", deletion_action=DeletionAction.MOVE_TO_PENDING) + ] diff --git a/src/sentry/monitors/models.py b/src/sentry/monitors/models.py index 851f94572e172a..53719f5379194e 100644 --- a/src/sentry/monitors/models.py +++ b/src/sentry/monitors/models.py @@ -580,22 +580,6 @@ def _update_timestamps(self): pass -@region_silo_model -class MonitorLocation(Model): - __relocation_scope__ = RelocationScope.Excluded - - guid = UUIDField(unique=True, auto_add=True) - name = models.CharField(max_length=128) - date_added = models.DateTimeField(default=timezone.now) - objects: ClassVar[BaseManager[Self]] = BaseManager(cache_fields=("guid",)) - - class Meta: - app_label = "sentry" - db_table = "sentry_monitorlocation" - - __repr__ = sane_repr("guid", "name") - - class MonitorEnvironmentManager(BaseManager["MonitorEnvironment"]): """ A manager that consolidates logic for monitor environment updates