From f62bb3fcd182ed1829418bc88397e4eaf0d72908 Mon Sep 17 00:00:00 2001 From: Raj Joshi Date: Fri, 18 Apr 2025 07:13:23 -0700 Subject: [PATCH] :wrench: chore: remove GA'ed email perf regression ff --- src/sentry/features/temporary.py | 1 - src/sentry/notifications/notifications/rules.py | 16 +++++----------- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/src/sentry/features/temporary.py b/src/sentry/features/temporary.py index b0363d109afc5b..8f4c77f36d44d8 100644 --- a/src/sentry/features/temporary.py +++ b/src/sentry/features/temporary.py @@ -110,7 +110,6 @@ def register_temporary_features(manager: FeatureManager): # Data Secrecy manager.add("organizations:data-secrecy", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) manager.add("organizations:devtoolbar", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, default=False, api_expose=True) - manager.add("organizations:email-performance-regression-image", OrganizationFeature, FeatureHandlerStrategy.OPTIONS, api_expose=False) # Enables synthesis of device.class in ingest manager.add("organizations:device-class-synthesis", OrganizationFeature, FeatureHandlerStrategy.INTERNAL, api_expose=False) # Enable device.class as a selectable column diff --git a/src/sentry/notifications/notifications/rules.py b/src/sentry/notifications/notifications/rules.py index 2071c007d2ed84..74158d47635f52 100644 --- a/src/sentry/notifications/notifications/rules.py +++ b/src/sentry/notifications/notifications/rules.py @@ -149,19 +149,13 @@ def get_recipient_context( } def get_image_url(self) -> str | None: - if features.has( - "organizations:email-performance-regression-image", self.group.organization - ): - image_builder = IssueAlertImageBuilder( - group=self.group, provider=ExternalProviderEnum.EMAIL - ) - return image_builder.get_image_url() - return None + image_builder = IssueAlertImageBuilder( + group=self.group, provider=ExternalProviderEnum.EMAIL + ) + return image_builder.get_image_url() def is_new_design(self) -> bool: - return features.has( - "organizations:email-performance-regression-image", self.group.organization - ) and self.group.issue_type in [ + return self.group.issue_type in [ PerformanceP95EndpointRegressionGroupType, ProfileFunctionRegressionType, ]