feat(ui): Fix /settings/ when user is not part of any orgs
#90771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix [todo] as the `/settings/` index page can link to invalid URLs when user is not apart of any orgs. Replace/remove all org links on this index page. Also fixes text clipping due to overflow + ellipsis.
github-actions
bot
added
the
Scope: Frontend
billyvg
changed the title
/settings/ when no org in context/settings/ when user is not part of any orgs
billyvg
commented
May 1, 2025
|
|
||
| const SelfHostedLink = icon ? HomeLinkIcon : HomeLink; | ||
| return <SelfHostedLink to={`${organizationSettingsUrl}support`} {...props} />; | ||
| return <SelfHostedLink to="https://sentry.zendesk.com/hc/en-us" {...props} />; |
Member
Author
There was a problem hiding this comment.
The prev support link, /settings/:orgSlug/support/ redirects to this.
scttcper
approved these changes
May 1, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
This should fix [this issue](https://sentry.sentry.io/issues/4191022159/?project=11276&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D%20useOrganization&referrer=issue-stream&stream_index=1) as the `/settings/` index page can link to invalid URLs when user is not apart of any orgs. (I actually think this *only* is visitable when the user is not part of any orgs, otherwise it redirects you to org settings). Replace/remove all org links on this index page. Also fixes text clipping due to overflow + ellipsis (look at the "g" in Organization) Old:  New:  Fixes JAVASCRIPT-2M6X
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix this issue as the
/settings/index page can link to invalid URLs when user is not apart of any orgs. (I actually think this only is visitable when the user is not part of any orgs, otherwise it redirects you to org settings). Replace/remove all org links on this index page.Also fixes text clipping due to overflow + ellipsis (look at the "g" in Organization)
Old:
New:
Fixes JAVASCRIPT-2M6X