From 13d156c089a938a945fdd43ef57734401212d835 Mon Sep 17 00:00:00 2001 From: Dominik Buszowiecki Date: Fri, 2 May 2025 11:56:42 -0400 Subject: [PATCH] set sampling mode --- .../landing/widgets/widgets/lineChartListWidget.tsx | 5 +++-- .../widgets/widgets/mobileReleaseComparisonListWidget.tsx | 3 ++- .../views/performance/landing/widgets/widgets/settings.ts | 7 +++++++ .../landing/widgets/widgets/singleFieldAreaWidget.tsx | 7 +++++-- 4 files changed, 17 insertions(+), 5 deletions(-) create mode 100644 static/app/views/performance/landing/widgets/widgets/settings.ts diff --git a/static/app/views/performance/landing/widgets/widgets/lineChartListWidget.tsx b/static/app/views/performance/landing/widgets/widgets/lineChartListWidget.tsx index 30021e3550bb9a..181aded98923ea 100644 --- a/static/app/views/performance/landing/widgets/widgets/lineChartListWidget.tsx +++ b/static/app/views/performance/landing/widgets/widgets/lineChartListWidget.tsx @@ -66,6 +66,7 @@ import { TOTAL_EXPANDABLE_ROWS_HEIGHT, } from 'sentry/views/performance/landing/widgets/utils'; import {PerformanceWidgetSetting} from 'sentry/views/performance/landing/widgets/widgetDefinitions'; +import {EAP_QUERY_PARAMS} from 'sentry/views/performance/landing/widgets/widgets/settings'; import {transactionSummaryRouteWithQuery} from 'sentry/views/performance/transactionSummary/utils'; import { createUnnamedTransactionsDiscoverTarget, @@ -117,11 +118,11 @@ export function LineChartListWidget(props: PerformanceWidgetProps) { const metricsDataset = useEap ? DiscoverDatasets.SPANS_EAP : DiscoverDatasets.METRICS; const spanQueryParams: Record = useEap - ? {useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP} + ? {...EAP_QUERY_PARAMS} : {dataset: DiscoverDatasets.SPANS_METRICS}; const metricsQueryParams: Record = useEap - ? {useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP} + ? {...EAP_QUERY_PARAMS} : {dataset: DiscoverDatasets.METRICS}; let emptyComponent: any; diff --git a/static/app/views/performance/landing/widgets/widgets/mobileReleaseComparisonListWidget.tsx b/static/app/views/performance/landing/widgets/widgets/mobileReleaseComparisonListWidget.tsx index 84bdc869bf2d48..f351f29ec367f5 100644 --- a/static/app/views/performance/landing/widgets/widgets/mobileReleaseComparisonListWidget.tsx +++ b/static/app/views/performance/landing/widgets/widgets/mobileReleaseComparisonListWidget.tsx @@ -56,6 +56,7 @@ import { TOTAL_EXPANDABLE_ROWS_HEIGHT, } from 'sentry/views/performance/landing/widgets/utils'; import {PerformanceWidgetSetting} from 'sentry/views/performance/landing/widgets/widgetDefinitions'; +import {EAP_QUERY_PARAMS} from 'sentry/views/performance/landing/widgets/widgets/settings'; import {Subtitle} from 'sentry/views/profiling/landing/styles'; import {RightAlignedCell} from 'sentry/views/replays/deadRageClick/deadRageSelectorCards'; @@ -119,7 +120,7 @@ function MobileReleaseComparisonListWidget(props: PerformanceWidgetProps) { : DiscoverDatasets.SPANS_METRICS; const queryParams: Record = useEap - ? {useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP} + ? {...EAP_QUERY_PARAMS} : {dataset: DiscoverDatasets.SPANS_METRICS}; const segmentOp = useEap ? 'span.op' : 'transaction.op'; diff --git a/static/app/views/performance/landing/widgets/widgets/settings.ts b/static/app/views/performance/landing/widgets/widgets/settings.ts new file mode 100644 index 00000000000000..3a9d7dfc17c166 --- /dev/null +++ b/static/app/views/performance/landing/widgets/widgets/settings.ts @@ -0,0 +1,7 @@ +import {DiscoverDatasets} from 'sentry/utils/discover/types'; +import {DEFAULT_SAMPLING_MODE} from 'sentry/views/insights/common/queries/useDiscover'; + +export const EAP_QUERY_PARAMS = { + dataset: DiscoverDatasets.SPANS_EAP, + sampling: DEFAULT_SAMPLING_MODE, +}; diff --git a/static/app/views/performance/landing/widgets/widgets/singleFieldAreaWidget.tsx b/static/app/views/performance/landing/widgets/widgets/singleFieldAreaWidget.tsx index 2266a39ea80aeb..860dab38f1cfde 100644 --- a/static/app/views/performance/landing/widgets/widgets/singleFieldAreaWidget.tsx +++ b/static/app/views/performance/landing/widgets/widgets/singleFieldAreaWidget.tsx @@ -8,7 +8,6 @@ import {t} from 'sentry/locale'; import {axisLabelFormatter} from 'sentry/utils/discover/charts'; import DiscoverQuery from 'sentry/utils/discover/discoverQuery'; import {aggregateOutputType} from 'sentry/utils/discover/fields'; -import {DiscoverDatasets} from 'sentry/utils/discover/types'; import type {Transform} from 'sentry/utils/performance/contexts/genericQueryBatcher'; import {QueryBatchNode} from 'sentry/utils/performance/contexts/genericQueryBatcher'; import {useMEPSettingContext} from 'sentry/utils/performance/contexts/metricsEnhancedSetting'; @@ -30,6 +29,7 @@ import { getMEPQueryParams, QUERY_LIMIT_PARAM, } from 'sentry/views/performance/landing/widgets/utils'; +import {EAP_QUERY_PARAMS} from 'sentry/views/performance/landing/widgets/widgets/settings'; type DataType = { chart: WidgetDataResult & ReturnType; @@ -45,7 +45,10 @@ export function SingleFieldAreaWidget(props: PerformanceWidgetProps) { const useEap = useInsightsEap(); const queryExtras = useEap - ? {...getMEPQueryParams(mepSetting), useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP} + ? { + ...getMEPQueryParams(mepSetting), + ...EAP_QUERY_PARAMS, + } : getMEPQueryParams(mepSetting); if (props.fields.length !== 1) {