Skip to content

Conversation

@ceorourke
Copy link
Member

Create a shared base class for the workflow engine serializer tests because they were redoing the same thing a lot.

@ceorourke ceorourke requested a review from a team as a code owner May 2, 2025 23:13
@ceorourke ceorourke requested a review from a team May 2, 2025 23:13
Copy link
Contributor

@snigdhas snigdhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👩‍🍳💋

@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #90869      +/-   ##
==========================================
+ Coverage   87.79%   87.81%   +0.01%     
==========================================
  Files       10284    10286       +2     
  Lines      583577   583891     +314     
  Branches    22574    22574              
==========================================
+ Hits       512376   512719     +343     
+ Misses      70787    70758      -29     
  Partials      414      414              

@ceorourke ceorourke merged commit 1b07524 into master May 5, 2025
57 checks passed
@ceorourke ceorourke deleted the ceorourke/refactor-workflow-engine-serializer-test-base-class branch May 5, 2025 16:13
andrewshie-sentry pushed a commit that referenced this pull request May 12, 2025
…ers (#90869)

Create a shared base class for the workflow engine serializer tests
because they were redoing the same thing a lot.
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants