ref(ourlogs): Always hide severity_number in the UI #96518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are looking to remove sending severity_number in lieu of 'severity' (aliased from sentry.severity_text), this will ensure it is unused before we remove it in Relay. This PR also adds the always hidden log keys as a new passable param to useTraceItemAttributes.
github-actions
bot
added
the
Scope: Frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96518 +/- ##
==========================================
- Coverage 86.55% 86.55% -0.01%
==========================================
Files 10654 10654
Lines 614810 614800 -10
Branches 24183 24182 -1
==========================================
- Hits 532129 532119 -10
Misses 82391 82391
Partials 290 290 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Bug: Test Fails Due to Deprecated Severity Field
The test incorrectly expects tree-key-severity_number to be rendered. The test data was updated to use SEVERITY instead of SEVERITY_NUMBER, and severity_number is now an AlwaysHiddenLogField that should not appear in the UI.
static/app/views/explore/logs/tables/logsTableRow.spec.tsx#L154-L158
sentry/static/app/views/explore/logs/tables/logsTableRow.spec.tsx
Lines 154 to 158 in d649926
Zylphrex
approved these changes
Jul 28, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 4, 2025
### Summary We are looking to remove sending severity_number in lieu of 'severity' (aliased from sentry.severity_text), this will ensure it is unused before we remove it in Relay. #### Other This PR also adds the always hidden log keys as a new passable param to useTraceItemAttributes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are looking to remove sending severity_number in lieu of 'severity' (aliased from sentry.severity_text), this will ensure it is unused before we remove it in Relay.
Other
This PR also adds the always hidden log keys as a new passable param to useTraceItemAttributes.