ref(replays): Add option which disables publishing to Snuba from Relay

[cmanallen]

Related: getsentry/sentry-kafka-schemas#434
Related: getsentry/relay#5088

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/replays/usecases/ingest/__init__.py	80.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #98353    +/-   ##
========================================
  Coverage   80.99%   80.99%            
========================================
  Files        8566     8570     +4     
  Lines      376863   377127   +264     
  Branches    24148    24148            
========================================
+ Hits       305225   305462   +237     
- Misses      71261    71288    +27     
  Partials      377      377            

[bruno-garcia]

@sentry review

[seer-by-sentry]

Potential bug: The feature to publish replay events to Snuba is non-functional due to a key mismatch. The code looks for relay_snuba_publish_disabled, but the option is named differently.

• Description: There is a mismatch between the configuration option name replay.relay-snuba-publishing-disabled and the key the consumer code attempts to retrieve from the recording payload, relay_snuba_publish_disabled. Because recording.get("relay_snuba_publish_disabled") in src/sentry/replays/consumers/recording.py will always return None, the should_publish_replay_event context value is always None. This causes the conditional check in src/sentry/replays/usecases/ingest/__init__.py to always evaluate to false. As a consequence, the publish_replay_event function is never called, rendering the feature to publish replay events to Snuba completely non-functional regardless of its configuration.

• Suggested fix: Correct the key used in src/sentry/replays/consumers/recording.py from relay_snuba_publish_disabled to match the key sent by Relay. Additionally, since the flag name implies disabling publishing, the conditional logic in src/sentry/replays/usecases/ingest/__init__.py may need to be inverted to correctly handle the flag's intent.
  _{severity: 0.8, confidence: 0.95}

_{Did we get this right? 👍 / 👎 to inform future reviews.}