Skip to content

feat(samplerate): add sdk sample rate #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2022
Merged

feat(samplerate): add sdk sample rate #129

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e26d6cc
feat(samplerate): add sdk sample rate
JonasBa Oct 4, 2022
0f32d35
Merge branch 'master' into jb/trace/sampleRate
JonasBa Oct 4, 2022
46a8c79
feat(sdk): await flush
JonasBa Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions server/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if (!config.SENTRY_DSN) {
throw new Error('SENTRY_DSN was not set in config.json');
}

Sentry.init({ dsn: config.SENTRY_DSN });
Sentry.init({ dsn: config.SENTRY_DSN, tracesSampleRate: 1 });

const storage = new Storage({
projectId: config.PROJECT
Expand Down Expand Up @@ -63,14 +63,16 @@ export function validateGeneratedFile(req: Request, res: Response) {
contentType: 'text/plain; charset=utf-8'
}
});
stream.on('error', err => {
stream.on('error', async err => {
res.status(500).send(err.message);
Sentry.captureException(err);
if (transaction) transaction.finish();
await Sentry.flush(5000);
});
stream.on('finish', () => {
stream.on('finish', async () => {
res.status(200).send(encodeURIComponent(objectName));
if (transaction) transaction.finish();
await Sentry.flush(5000);
});

stream.end(JSON.stringify(report));
Expand Down