Tag consumer latency metric and rename to latency_sec#322
Merged
Conversation
Rename streams.pipeline.consumer.watermark_commit_latency to streams.pipeline.consumer.latency_sec. Emit consumer_group and topic tags from WatermarkCommitOffsets, wired from ArroyoConsumer via PyKafkaConsumerConfig::group_id(). Co-authored-by: Cursor <cursoragent@cursor.com>
bmckerry
approved these changes
May 14, 2026
george-sentry
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
streams.pipeline.consumer.watermark_commit_latencytostreams.pipeline.consumer.latency_sec(values remain seconds from watermarklast_message_timeto commit decision).consumer_groupandtopicon that histogram, populated fromArroyoConsumer(Kafka group id and subscribed topic).PyKafkaConsumerConfig::group_id()for Rust access to the configured consumer group.Test plan
cargo test commit_policy,cargo test test_build_chain,cargo test test_watermark_to_commit,cargo test test_pykafka_consumerMade with Cursor