fix(debuginfo): Avoid infinite recursion because of self references #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Apr 1, 2020
debuginfo/src/dwarf.rs
Outdated
| { | ||
| ref_unit.resolve_function_name(ref_entry) | ||
| } else { | ||
| Err(DwarfErrorKind::SelfReference.into()) |
There was a problem hiding this comment.
Just to confirm, are you sure you don't just want to return Ok(None) here?
There was a problem hiding this comment.
Or maybe just return an Option instead of a Result since resolve_function_name is only used in functions() and remove the ok().flatten(). I can do that in a follow-up PR. Wdyt ?
There was a problem hiding this comment.
I'd keep the result if the Dwarf is really invalid (used in resolve_reference). But it's already a Result<Option<_>>, so just returning Ok(None) here should be the ideal compromise imho.
jan-auer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.