fix(cfi): Skip invalid CFI entries instead of erroring out #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
approved these changes
May 7, 2020
jan-auer
force-pushed
the
fix/skip-invalid-cfi-entries
branch
from
f91d9bc
to
529b2ea
Compare
jan-auer
added a commit
that referenced
this pull request
May 7, 2020
* master: fix(cfi): Skip invalid CFI entries instead of erroring out (#232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've encountered files that contain CFI entries pointing before the load address of the image. Such entries are invalid, since they cannot be mapped to a relative address. Since such a file can still contain valid entries, rather skip them and continue.