Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wasmparser to 0.85.0 #624

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Conversation

bnjbvr
Copy link
Contributor

@bnjbvr bnjbvr commented Jul 19, 2022

No description provided.

@bnjbvr bnjbvr requested a review from a team July 19, 2022 14:10
@codecov-commenter
Copy link

Codecov Report

Merging #624 (5935b6c) into master (7d4e25a) will increase coverage by 0.17%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
+ Coverage   69.19%   69.36%   +0.17%     
==========================================
  Files          84       84              
  Lines       16873    16674     -199     
==========================================
- Hits        11675    11566     -109     
+ Misses       5198     5108      -90     

symbolic-debuginfo/src/wasm/parser.rs Outdated Show resolved Hide resolved
Co-authored-by: Arpad Borsos <swatinem@swatinem.de>
@Swatinem Swatinem merged commit ab8e248 into getsentry:master Jul 20, 2022
@mstange
Copy link
Contributor

mstange commented Aug 3, 2022

This update caused symbolic's MSRV to increase to 1.58, due to format strings:

   Compiling wasmparser v0.85.0
     Running `rustc --crate-name h2 --edition=2018 /builds/worker/.cargo/registry/src/github.com-1ecc6299db9ec823/h2-0.3.13/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C metadata=c07b053115373f91 -C extra-filename=-c07b053115373f91 --out-dir /builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps --target x86_64-apple-darwin -L dependency=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps -L dependency=/builds/worker/fetches/dump_syms/target/release/deps --extern bytes=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libbytes-a4b23a77b0d5639d.rmeta --extern fnv=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libfnv-f506945c14519358.rmeta --extern futures_core=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libfutures_core-4ae7d23cd314e184.rmeta --extern futures_sink=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libfutures_sink-4356175d269ba6f3.rmeta --extern futures_util=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libfutures_util-180a405b8e489ac3.rmeta --extern http=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libhttp-8fc2ea9c09aed8dc.rmeta --extern indexmap=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libindexmap-960a8110a8ca7502.rmeta --extern slab=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libslab-45b91366405779c5.rmeta --extern tokio=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libtokio-72d235f02e51c747.rmeta --extern tokio_util=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libtokio_util-2766438102773de9.rmeta --extern tracing=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libtracing-af2e4cf1942fa091.rmeta --cap-lints allow -C linker=/builds/worker/workspace/build/src/taskcluster/scripts/misc/osx-cross-linker`
     Running `rustc --crate-name wasmparser --edition=2021 /builds/worker/.cargo/registry/src/github.com-1ecc6299db9ec823/wasmparser-0.85.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C metadata=33ce9de1a0097475 -C extra-filename=-33ce9de1a0097475 --out-dir /builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps --target x86_64-apple-darwin -L dependency=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps -L dependency=/builds/worker/fetches/dump_syms/target/release/deps --extern indexmap=/builds/worker/fetches/dump_syms/target/x86_64-apple-darwin/release/deps/libindexmap-960a8110a8ca7502.rmeta --cap-lints allow -C linker=/builds/worker/workspace/build/src/taskcluster/scripts/misc/osx-cross-linker`
error: there is no argument named `func_index`
   --> /builds/worker/.cargo/registry/src/github.com-1ecc6299db9ec823/wasmparser-0.85.0/src/validator/component.rs:188:110
    |
188 | ...   format!("lowered parameter types `{:?}` do not match parameter types `{:?}` of core function {func_index}", params.as_slice(), core...
    |                                                                                                    ^^^^^^^^^^^^

error: there is no argument named `func_index`
   --> /builds/worker/.cargo/registry/src/github.com-1ecc6299db9ec823/wasmparser-0.85.0/src/validator/component.rs:195:104
    |
195 | ...   format!("lowered result types `{:?}` do not match result types `{:?}` of core function {func_index}", results.as_slice(), core_ty.r...
    |                                                                                              ^^^^^^^^^^^^

error: there is no argument named `MAX_WASM_TYPE_SIZE`
  --> /builds/worker/.cargo/registry/src/github.com-1ecc6299db9ec823/wasmparser-0.85.0/src/validator.rs:83:63
   |
83 |             format!("effective type size exceeds the limit of {MAX_WASM_TYPE_SIZE}"),
   |                                                               ^^^^^^^^^^^^^^^^^^^^

error: could not compile `wasmparser` due to 3 previous errors

@Swatinem
Copy link
Member

Swatinem commented Aug 4, 2022

We don’t have an MSRV for symbolic, the readme even states (https://github.com/getsentry/symbolic#building-and-development):

To build the Rust crate, we require the latest stable Rust, as well as a C++11 compiler.

I think thats even a C++14 compiler by now due to Swift demangling.

@bnjbvr bnjbvr deleted the bump-wasmparser branch August 4, 2022 08:45
@mstange
Copy link
Contributor

mstange commented Aug 4, 2022

Ah, I see. That's fair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants