Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Upgrade to Actix 1 #106

Merged
merged 19 commits into from Aug 12, 2019
Merged

ref: Upgrade to Actix 1 #106

merged 19 commits into from Aug 12, 2019

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Aug 4, 2019 •
edited

This refactors the entire web layer including middlewares and restructures services. To speed up compilation, many impl Trait have been replaced with Boxes. Also, the library and binary crate have been merged into one. Rust tests also need less hacks now.

The inner works of services (e.g. symbol lookup) has not been touched!

Since the diff is pretty unusable, I suggest to review the outcome directly. Ideally, start from main, follow to server::run and Service::create, and then look at the endpoints and middlewares.

The Sentry middleware and utilities can later be moved into a new version of sentry-actix, and I would also propose to create a new crate, sentry-futures.

@jan-auer jan-auer self-assigned this Aug 4, 2019
jan-auer and others added 5 commits August 4, 2019 21:35
@jan-auer
Merge branch 'master' into wip/actix-1
a57eeac 
* master:
  test(insta): Upgrade insta to fix snapshot paths (#105)
  fix(docker): chown default data directory (#104)
  build: Update symbolic to fix PDB UnexpectedEof issue
@jan-auer
ref: Remove unused commented-out code
1ff13dc
@untitaker
fix: start_response before body
46cb54c
@untitaker
fix: Add more debugging code
803c3bd
@jan-auer
ci: Run integration tests sequentially
7c60503
untitaker
untitaker approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this because the code looks fine to me, ofc the tests need to be fixed

@jan-auer
Copy link
Member Author

jan-auer commented Aug 8, 2019

Tests are green now 🤷‍♂

@untitaker See 0b0cc2a. This commit contains the fix for failing CAB extraction. The doc comments describe the reason for this fix. Summary: The file is only namable, until NamedTemporaryFile is dropped.

@jan-auer jan-auer requested a review from untitaker August 8, 2019 06:26
@jan-auer
Copy link
Member Author

FWIW, test failures were caused by file descriptor limits. With the logs at hand this was not completely obvious, but we can work on surfacing them better.

@jan-auer jan-auer merged commit 210207b into master Aug 12, 2019
@jan-auer jan-auer deleted the wip/actix-1 branch August 12, 2019 13:14
@jan-auer jan-auer mentioned this pull request Aug 12, 2019
Merged
@jan-auer jan-auer mentioned this pull request Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-auer @untitaker