fix(shared-cache): At startup retry token retrieval #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At k8s pod startup time the GKE metadata service might not give us tokens right away, with errors ranging from connection refused to transient http errors. So we need to keep trying for a bit longer. This also adds the timeout on the token retrieval for writing to the shared cache, otherwise those tasks would indefinitely stall (which isn't the worst thing ever since they sit in a bounded queue). Fixes: SYMBOLICATOR-NK
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
=========================================
Coverage ? 73.16%
=========================================
Files ? 48
Lines ? 10592
Branches ? 0
=========================================
Hits ? 7750
Misses ? 2842
Partials ? 0 Continue to review full report at Codecov.
|
Swatinem
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At k8s pod startup time the GKE metadata service might not give us
tokens right away, with errors ranging from connection refused to
transient http errors. So we need to keep trying for a bit longer.
This also adds the timeout on the token retrieval for writing to the
shared cache, otherwise those tasks would indefinitely stall (which
isn't the worst thing ever since they sit in a bounded queue).
Fixes: SYMBOLICATOR-NK
#skip-changelog