Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to filter tests with warnings #579

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add option to filter tests with warnings #579

wants to merge 1 commit into from

Conversation

maormarcus
Copy link
Contributor

No description provided.

@vmalloc
Copy link
Member

vmalloc commented Oct 10, 2019

This could cause a DoS. num_warnings isn't indexed at the moment, and indexing it could take a very long time on an existing DB...

@maormarcus
Copy link
Contributor Author

I see. Any suggestions how we can implement this feature otherwise?
The fact that we show this option only in the view of specific session index doesn't mean that it will look only on num_warnings of this specific session tests?

@vmalloc
Copy link
Member

vmalloc commented Oct 14, 2019

@maormarcus assuming we restrict it to session view (i.e. trying to filter all tests with it yields a syntax error) - it should be fine

@maormarcus
Copy link
Contributor Author

@vmalloc i tried to fix this, can you take a look?

@maormarcus
Copy link
Contributor Author

@vmalloc can you please take a look again? i spitted the args.search to tokens so now test_has_warnings etc should be ok.

@vmalloc
Copy link
Member

vmalloc commented Jan 20, 2020

@maormarcus need to rebase this on top of latest develop...

@maormarcus
Copy link
Contributor Author

@vmalloc done, thanks!

vmalloc
vmalloc requested changes Jan 20, 2020
View reviewed changes
webapp/app/session/index/template.hbs
@@ -33,6 +33,10 @@
<td><code>starred</code></td>
<td>Find tests which the current user marked as starred</td>
</tr>
<tr>
<td><code>has_warnings</code></td>
<td>Find tests that has warnings</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find tests that have warnings

@vmalloc
Copy link
Member

vmalloc commented Jan 20, 2020

This is still not 100% correct, but I'm guessing is good enough (search tokinzation is not based on whitespaces)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmalloc vmalloc vmalloc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maormarcus @vmalloc