Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pattern matching for whitespaces after "tag:" (closes #964) #965

Merged
merged 1 commit into from Aug 4, 2019

Conversation

@vmalloc
Copy link
Member

commented Aug 2, 2019

No description provided.

@vmalloc vmalloc force-pushed the bugfix/964 branch from 2c62c01 to a30f625 Aug 2, 2019

@vmalloc vmalloc requested a review from ayalash Aug 2, 2019

@vmalloc vmalloc force-pushed the bugfix/964 branch from a30f625 to 3f34825 Aug 2, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 2, 2019

Codecov Report

Merging #965 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #965      +/-   ##
===========================================
- Coverage    93.15%   93.14%   -0.02%     
===========================================
  Files           83       83              
  Lines         6691     6692       +1     
===========================================
  Hits          6233     6233              
- Misses         458      459       +1
Impacted Files Coverage Δ
slash/utils/pattern_matching.py 100% <100%> (ø) ⬆️
slash/parallel/parallel_manager.py 98.29% <0%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 070152f...3f34825. Read the comment docs.

@ayalash

ayalash approved these changes Aug 4, 2019

@ayalash

This comment has been minimized.

Copy link
Collaborator

commented Aug 4, 2019

@vmalloc Thanks!!

@ayalash ayalash merged commit 892c059 into develop Aug 4, 2019

4 checks passed

codecov/patch 100% of diff hit (target 93.15%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +6.84% compared to 070152f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bors bors bot deleted the bugfix/964 branch Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.