Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation pipeline #971

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@ayalash
Copy link
Collaborator

commented Sep 3, 2019

Releases package is currently broken with newest semantic-version package, which is one of its dependencies (see bitprophet/releases#84).

In addition, it depends on Sphinx<1.8.

I pinned these 3 packages (in doc extras) until the issue will be fixed.

@ayalash ayalash requested a review from vmalloc Sep 3, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

Merging #971 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #971   +/-   ##
========================================
  Coverage    93.03%   93.03%           
========================================
  Files           83       83           
  Lines         6665     6665           
========================================
  Hits          6201     6201           
  Misses         464      464
Impacted Files Coverage Δ
slash/parallel/parallel_manager.py 98.29% <0%> (-0.86%) ⬇️
slash/parallel/worker.py 85.08% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2b767...54e2ed1. Read the comment docs.

@vmalloc
vmalloc approved these changes Sep 3, 2019
Copy link
Member

left a comment

LGTM

@ayalash ayalash merged commit 4eb0547 into develop Sep 3, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 8c2b767...54e2ed1
Details
codecov/project 93.03% remains the same compared to 8c2b767
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ayalash ayalash deleted the ayalas/fix_pipeline branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.