Add python3_avx2_lib_shift macro and and add extra check for avx2_lib_shift #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we are trying to move files around which don't exist
This appends python solib files with an avx2 extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python3_avx2_lib_shift macro will append a .avx2 extension to all python3 .so files in the $installdir. This is intended to be the last command to run as part of the the install step for avx2 builds. This allows a patched python to load the optimized .so.avx2 if a supported cpu is found.
An extra check is added to avx2_lib_shift to ensure it doesn't try and move around files which don't exist. Without this change avx2_lib_shift tries to run automatically after install and would fail for python module avx2 builds.
Generally, this is intended to be good-enough until YPKG3 as I don't want to import too much resources into something which will soon be swapped out. Hopefully for YPKG3 the equivalent of python3_avx2_lib_shift would be able to be run automagically.