Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`kbd` element not considered as raw text #112

Closed
ddfreyne opened this issue Mar 17, 2014 · 6 comments
Closed

`kbd` element not considered as raw text #112

ddfreyne opened this issue Mar 17, 2014 · 6 comments

Comments

@ddfreyne
Copy link

@ddfreyne ddfreyne commented Mar 17, 2014

kramdown.rb, line #184 specifies that the script, pre and code element have raw text, so that no smart typographical conversions are made (-- to en-dash etc).

I believe this list of elements should also include kbd. Otherwise, long-form commandline options (e.g. --version) need to be escaped:

Ruby may already be installed on your system. To check, open a terminal window
and type <kbd>ruby \--version</kbd>.

Without the backslash, the -- is turned into an en-dash.

@gettalong
Copy link
Owner

@gettalong gettalong commented Mar 17, 2014

You are referencing the kramdown converter and not the parser - any specific reason?

@ddfreyne
Copy link
Author

@ddfreyne ddfreyne commented Mar 18, 2014

@gettalong Not sure. The only place where I could find where text is considered as “raw” was in that specific place.

@gpakosz
Copy link

@gpakosz gpakosz commented May 6, 2014

what gives?

@gettalong
Copy link
Owner

@gettalong gettalong commented Jun 2, 2014

Not sure what to do about this... The HTML converter is the false place since by then the en-dash is already created as an element.

@ddfreyne
Copy link
Author

@ddfreyne ddfreyne commented Jun 3, 2014

@gettalong I am not sure where the fix should be, but I do know that the contents of the kbd element should be treated as raw, just like code, script etc.

@gettalong gettalong closed this in b8c6131 Jun 3, 2014
@ddfreyne
Copy link
Author

@ddfreyne ddfreyne commented Jun 3, 2014

Awesome, thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.