rouge support?

[jneen]

Hey there, there was a discussion about ways to add an option to use rouge instead of coderay, and it seems to have trailed off. ( #68 (comment) ). For my own personal use, I can just write a little bit of glue code myself that overrides the highlighting behavior, but it seems some people want a more packaged solution. ( rouge-ruby/rouge#118 ). What's the best integration point here?

[gettalong]

@jneen I have updated the code to allow pluggable syntax highlighters (See 49e1b12). The coderay specific stuff has be moved in such a syntax highlighter implementation and I will add a rouge implementation the coming days before the next release.

Just a quick question: Syntax highlighting inline code with rouge is done by using wrap: false, is this correct? I have looked at the rouge plugin for redcarpet and modeled the kramdown implementation on it but that implementation doesn't discriminate between block and span code.

[jneen]

Awesome, thanks!

Ah yes, iirc the redcarpet plugin doesn't get called for span code, so it's just unhighlighted. For span code I'd use wrap: false and manually wrap with whatever span you like.

[gettalong]

Perfect, thanks for the fast answer!

[gettalong]

@jneen Rouge support has been added with commit 199e5ec - it's more or less a straight port from the redcarpet plugin. However, since I'm not that familiar with Rouge it would be great if you could have a look at the implementation (see https://github.com/gettalong/kramdown/blob/199e5ecf256497add54e6a097796d64cf0925b00/lib/kramdown/converter/syntax_highlighter/rouge.rb) - thanks!

[gettalong]

@jneen Thanks for your comments! The next version will ship next week with these changes.

[jneen]

Thanks for your work! I look forward to it. Let me know when that goes out, I'll get back to some people about it.

👏

[gettalong]

@jneen I have just released version 1.5.0 with rouge support - also see https://twitter.com/_gettalong/status/526122568181628928