-
-
Notifications
You must be signed in to change notification settings - Fork 279
Support "-" (dash) in name of code block lang #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, I would accept it. I still have to have a look at the code to determine if this would have a side effect but I don't think so. The change should be backwards-compatible because valid fenced code blocks are not affected. |
I opened a new PR using my private account. |
@maxmeyer Just one question before we go further: Wouldn't it be easier to just use an underscore instead of a dash in your custom language? Or is there another reason? |
To make it short: It's a reason for style and maybe compatibility with concurrent frameworks. I would like to integrate mermaid into middleman-presentation via "code blocks":
I'm using a custom kramdown code block converter already so I'm able to generate the HTML stuff in a way I need. Using code blocks raise a problem "for me": What if a user wants to highlight the mermaid code instead of rendering a graph? It looks like the guys over here decided to use something like this to make it possible:
Personally I like the |
BTW: |
Okay, thanks for explaining your reasons. |
Thanks for everything, your changes from #246 are now in master. |
Hi @gettalong,
are you going to accept a PR which makes it possible to use a dash in the code block language?
Maybe it's just this line which needs to be changed to
The text was updated successfully, but these errors were encountered: