Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening quotation mark with ellipsis problem #253

Closed
michaelfranzl opened this issue May 12, 2015 · 2 comments
Closed

Opening quotation mark with ellipsis problem #253

michaelfranzl opened this issue May 12, 2015 · 2 comments
Assignees

Comments

@michaelfranzl
Copy link

This

Kramdown::Document.new('"abc def"').to_latex

correctly puts opening and closing quotation marks:

``abc def''

Whereas having an ellipsis at the beginning of the quote

Kramdown::Document.new('"...abc def"').to_latex

gives two closing quotation marks

 ''\\ldots{}abc def''

Behavior is the same for HTML and LaTeX output. It's not a big issue, but having an ellipsis at the beginning of a quotation is quite common in typesetting.

@gettalong gettalong self-assigned this May 14, 2015
@gettalong
Copy link
Owner

The smart quote feature in kramdown is certainly not complete and getting this right in general is a really hard problem. If I were to create kramdown now I would probably leave the smart quotes out completely.

However, I think that in this case it would a) be easy to add and b) pose no compatibility problems - I will have a look.

@gettalong
Copy link
Owner

I have added some code to allow the requested behavior. However, I'm not entirely sure if the change has any side effects but I don't think so. The test suite still passes but that is not a 100% verification.

Tl;dr: Will be in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants