Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<mark> treated as block tag #298

Closed
ndarville opened this issue Dec 18, 2015 · 7 comments
Closed

<mark> treated as block tag #298

ndarville opened this issue Dec 18, 2015 · 7 comments
Assignees
Labels

Comments

@ndarville
Copy link

Using Seems to have the result of removing <p> tags when writing in Jekyll.

Markdown input:

Lorem ipsum.

<mark>Test</mark>

<mark>Foobar</mark>

HTML output:

<p>Lorem ipsum.</p>

<mark>Test</mark>

<mark>Foobar</mark>
$ bundle exec kramdown -v
1.9.0

I thought it might have to do with the tag being treated as an unknown tag or a block tag given the behaviour, but the main problem is that using markdown=“1" and markdown="span" doesn’t fix it either.

I take it this can’t be expected behaviour, at least if you can’t mitigate it with the markdown attribute. Or does is it “not working, as expected”, if you will? :)

I’ll be using <span class="highlight"> for now, but that’s obviously not ideal for a number of reasons.

@gettalong gettalong self-assigned this Dec 18, 2015
@gettalong
Copy link
Owner

Sorry, I don't fully understand the problem. The <mark> tag is not a valid HTML tag. Can you provide input, current output and expected output?

@ndarville
Copy link
Author

Has it been deprecated?

@gettalong
Copy link
Owner

Ah, okay, didn't know that it was a HTML5 tag. Okay, so this is a span-level tag like <b>. And what is the exact problem?

@ndarville
Copy link
Author

The rendered HTML is

<p>Lorem ipsum.</p>

<mark>Test</mark>

<mark>Foobar</mark>

when it should be

<p>Lorem ipsum.</p>

<p><mark>Test</mark></p>

<p><mark>Foobar</mark></p>
- <mark>Test</mark>
+ <p><mark>Test</mark></p>

- <mark>Foobar</mark>
+ <p><mark>Foobar</mark></p>

@gettalong gettalong added the bug label Dec 18, 2015
@gettalong
Copy link
Owner

Okay, that should be easy to fix - thanks for the bug report!

@ndarville
Copy link
Author

No problem, appreciate the fast reply!

@ndarville
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants