New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<mark> treated as block tag #298

Closed
ndarville opened this Issue Dec 18, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@ndarville

ndarville commented Dec 18, 2015

Using Seems to have the result of removing <p> tags when writing in Jekyll.

Markdown input:

Lorem ipsum.

<mark>Test</mark>

<mark>Foobar</mark>

HTML output:

<p>Lorem ipsum.</p>

<mark>Test</mark>

<mark>Foobar</mark>
$ bundle exec kramdown -v
1.9.0

I thought it might have to do with the tag being treated as an unknown tag or a block tag given the behaviour, but the main problem is that using markdown=“1" and markdown="span" doesn’t fix it either.

I take it this can’t be expected behaviour, at least if you can’t mitigate it with the markdown attribute. Or does is it “not working, as expected”, if you will? :)

I’ll be using <span class="highlight"> for now, but that’s obviously not ideal for a number of reasons.

@gettalong gettalong self-assigned this Dec 18, 2015

@gettalong

This comment has been minimized.

Owner

gettalong commented Dec 18, 2015

Sorry, I don't fully understand the problem. The <mark> tag is not a valid HTML tag. Can you provide input, current output and expected output?

@ndarville

This comment has been minimized.

ndarville commented Dec 18, 2015

Has it been deprecated?

@gettalong

This comment has been minimized.

Owner

gettalong commented Dec 18, 2015

Ah, okay, didn't know that it was a HTML5 tag. Okay, so this is a span-level tag like <b>. And what is the exact problem?

@ndarville

This comment has been minimized.

ndarville commented Dec 18, 2015

The rendered HTML is

<p>Lorem ipsum.</p>

<mark>Test</mark>

<mark>Foobar</mark>

when it should be

<p>Lorem ipsum.</p>

<p><mark>Test</mark></p>

<p><mark>Foobar</mark></p>
- <mark>Test</mark>
+ <p><mark>Test</mark></p>

- <mark>Foobar</mark>
+ <p><mark>Foobar</mark></p>

@gettalong gettalong added the bug label Dec 18, 2015

@gettalong

This comment has been minimized.

Owner

gettalong commented Dec 18, 2015

Okay, that should be easy to fix - thanks for the bug report!

@ndarville

This comment has been minimized.

ndarville commented Dec 18, 2015

No problem, appreciate the fast reply!

@ndarville

This comment has been minimized.

ndarville commented Feb 17, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment