New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression for underscore emphasis in version 1.11.0 #333

Closed
stomar opened this Issue May 1, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@stomar
Contributor

stomar commented May 1, 2016

Version 1.11.0 breaks parsing of underscore emphasis in some cases. This is most probably caused by commit c972cc2.

Below there are some examples for cases where parsing fails; note that especially for quotation marks there is a wide variety of used symbols, depending on language.

(Maybe some test cases should be added?)

Source:

ok:

- _test_
- '_test_'
- "_test_"
- ("_test_")

Not ok:

- (_test_)
-_test_- \`_test_'
-_test_“ (German style)

With 1.11.0 this results in:

<p>ok:</p>

<ul>
  <li><em>test</em></li>
  <li>‘<em>test</em>’</li>
  <li>“<em>test</em>”</li>
  <li>(“<em>test</em>”)</li>
</ul>

<p>Not ok:</p>

<ul>
  <li>(_test_)</li>
  <li>“_test_”</li>
  <li>`_test_’</li>
  <li>„_test_“ (German style)</li>
</ul>

With 1.10.0 everything is fine:

<p>ok:</p>

<ul>
  <li><em>test</em></li>
  <li>‘<em>test</em>’</li>
  <li>“<em>test</em>”</li>
  <li>(“<em>test</em>”)</li>
</ul>

<p>Not ok:</p>

<ul>
  <li>(<em>test</em>)</li>
  <li>“<em>test</em>”</li>
  <li>`<em>test</em>’</li>
  <li>„<em>test</em>“ (German style)</li>
</ul>

@gettalong gettalong self-assigned this May 1, 2016

@gettalong gettalong added the bug label May 1, 2016

@gettalong gettalong closed this in 12f49e2 May 1, 2016

@gettalong

This comment has been minimized.

Owner

gettalong commented May 1, 2016

Thanks for reporting and the additional test cases - I have just released a bug fix version.

@stomar

This comment has been minimized.

Contributor

stomar commented May 1, 2016

Thanks for the fast fix, the new release works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment