Skip to content

Regression for underscore emphasis in version 1.11.0 #333

@stomar

Description

@stomar

Version 1.11.0 breaks parsing of underscore emphasis in some cases. This is most probably caused by commit c972cc2.

Below there are some examples for cases where parsing fails; note that especially for quotation marks there is a wide variety of used symbols, depending on language.

(Maybe some test cases should be added?)

Source:

ok:

- _test_
- '_test_'
- "_test_"
- ("_test_")

Not ok:

- (_test_)
-_test_- \`_test_'
-_test_“ (German style)

With 1.11.0 this results in:

<p>ok:</p>

<ul>
  <li><em>test</em></li>
  <li><em>test</em></li>
  <li><em>test</em></li>
  <li>(“<em>test</em>”)</li>
</ul>

<p>Not ok:</p>

<ul>
  <li>(_test_)</li>
  <li>“_test_”</li>
  <li>`_test_’</li>
  <li>„_test_“ (German style)</li>
</ul>

With 1.10.0 everything is fine:

<p>ok:</p>

<ul>
  <li><em>test</em></li>
  <li><em>test</em></li>
  <li><em>test</em></li>
  <li>(“<em>test</em>”)</li>
</ul>

<p>Not ok:</p>

<ul>
  <li>(<em>test</em>)</li>
  <li><em>test</em></li>
  <li>`<em>test</em></li>
  <li><em>test</em>“ (German style)</li>
</ul>

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions