New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kramdown escapes all the symbols in emails #343

Closed
anton-tsyganenko opened this Issue Jun 6, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@anton-tsyganenko

anton-tsyganenko commented Jun 6, 2016

$ echo "<me.example@example.com>" | kramdown
<p><a href="&#109;&#097;&#105;&#108;&#116;&#111;:&#109;&#101;&#046;&#101;&#120;&#097;&#109;&#112;&#108;&#101;&#064;&#101;&#120;&#097;&#109;&#112;&#108;&#101;&#046;&#099;&#111;&#109;">&#109;&#101;&#046;&#101;&#120;&#097;&#109;&#112;&#108;&#101;&#064;&#101;&#120;&#097;&#109;&#112;&#108;&#101;&#046;&#099;&#111;&#109;</a></p>
$ kramdown --version
1.11.1

@gettalong gettalong self-assigned this Jun 8, 2016

@gettalong gettalong added the question label Jun 8, 2016

@gettalong

This comment has been minimized.

Owner

gettalong commented Jun 8, 2016

Could you describe the problem?

@anton-tsyganenko

This comment has been minimized.

anton-tsyganenko commented Jun 8, 2016

I want it to give result without escaping ascii-characters, like this:
<p><a href="mailto:me.example@example.com">me.example@example.com</a></p>
but it escapes everything. It is shown correct in the browser, but it increases source code length and size and decreases its readability.

@gettalong

This comment has been minimized.

Owner

gettalong commented Jun 8, 2016

Okay, that is by design and to be compatible in this regard with the original Markdown.pl implementation.

@gettalong gettalong closed this Jun 8, 2016

@anton-tsyganenko

This comment has been minimized.

anton-tsyganenko commented Jun 8, 2016

In another way of setting email links the results differ:

$ echo "[a@b.c](mailto:a@b.c)" | markdown
<p><a href="mailto:a@b.c">a@b.c</a></p>
$ echo "[a@b.c](mailto:a@b.c)" | kramdown 
<p><a href="&#109;&#097;&#105;&#108;&#116;&#111;:&#097;&#064;&#098;&#046;&#099;">&#097;&#064;&#098;&#046;&#099;</a></p>
@gettalong

This comment has been minimized.

Owner

gettalong commented Jun 8, 2016

Don't know that markdown executable, so I can't say. Fact of the matter is: It is how it is. And if there is no good reason to change it (and you have provided none), I won't change it.

@anton-tsyganenko

This comment has been minimized.

anton-tsyganenko commented Jun 8, 2016

Don't know that markdown executable, so I can't say.

That one: https://www.archlinux.org/packages/community/any/markdown/

@gettalong gettalong added enhancement and removed question labels Jun 8, 2016

@gettalong

This comment has been minimized.

Owner

gettalong commented Jun 8, 2016

Thanks, since it seems that most other implementations don't obfuscate the email links anymore, kramdown should probably follow suit in this case.

@gettalong gettalong reopened this Jun 8, 2016

@gettalong

This comment has been minimized.

Owner

gettalong commented Aug 6, 2016

The obfuscation will be removed in the next release.

@gettalong gettalong closed this Aug 6, 2016

gettalong added a commit that referenced this issue Aug 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment