/kramdown

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base#adapt_source modifies input string in-place #40

Closed
ddfreyne opened this Issue Mar 11, 2013 · 1 comment

Comments

Assignees

@gettalong gettalong

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ddfreyne @gettalong
@ddfreyne

ddfreyne commented Mar 11, 2013

Kramdown::Parser::Base#adapt_source modifies the encoding of the input string in-place (source). I don’t believe it should; input arguments should not be touched.

Possible fix: replace

source.encode!('UTF-8')

with

source = source.encode('UTF-8')

(Related nanoc issues: nanoc/nanoc#276, nanoc/nanoc#277)

This was referenced Mar 11, 2013

Closed
Merged

@ghost ghost assigned gettalong Mar 11, 2013

@gettalong

This comment has been minimized.

Sign in to view
Owner

gettalong commented Mar 11, 2013

Yep, you are right.

@gettalong gettalong closed this Mar 11, 2013

gettalong added a commit that referenced this issue Mar 11, 2013

@gettalong
Don't modify the given source string in place, fixes GH issue #40
b8cadae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment