New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No or invalid attributes found in IAL/ALD content – for simple {::comment} #42

Closed
DHB opened this Issue Mar 20, 2013 · 6 comments

Comments

Projects
None yet
3 participants
@DHB

DHB commented Mar 20, 2013

$ ruby --version && gem --version && bundle --version
ruby 2.0.0p0 (2013-02-24) [i386-mingw32]
2.0.3
Bundler version 1.3.4
$ gem list --local kr

*** LOCAL GEMS ***

kramdown (1.0.1)

test.md

{::comment}
abcdefghijklmnopqrstuvwxyz 0123456789                                                     
{:/comment}

# TEST

Executing kramdown results in:

$ kramdown test.md   > test.html
Warning: No or invalid attributes found in IAL/ALD content:
@DHB

This comment has been minimized.

DHB commented Mar 20, 2013

forgot to mention: This was no problem in kramdown 0.14.2.

@gettalong

This comment has been minimized.

Owner

gettalong commented Mar 20, 2013

Thanks for reporting! There should definitely not be a warning in this case.

@ghost ghost assigned gettalong Mar 20, 2013

@DHB

This comment has been minimized.

DHB commented Mar 20, 2013

This is low priority - No real rush or urgency from my side. I also forgot to say thank you for all your efforts and for this wonderful gem!! Danke.

@cabo

This comment has been minimized.

cabo commented Apr 13, 2013

Here is my little test case…

$ echo '{::nomarkdown}{:/nomarkdown}' | kramdown >/dev/null
Warning: No or invalid attributes found in IAL/ALD content: 

(Users of kramdown-rfc2629 get this around five times for every invocation…)

Fix:

--- kramdown-1.0.1/lib/kramdown/parser/kramdown/extensions.rb~
+++ kramdown-1.0.1/lib/kramdown/parser/kramdown/extensions.rb
@@ -16,6 +16,7 @@
       # Parse the string +str+ and extract all attributes and add all found attributes to the hash
       # +opts+.
       def parse_attribute_list(str, opts)
+        return if str == ''
         attrs = str.scan(ALD_TYPE_ANY)
         attrs.each do |key, sep, val, ref, id_and_or_class, _, _|
           if ref
@DHB

This comment has been minimized.

DHB commented Apr 13, 2013

Yup, this fixed it nicely.

@cabo : Thank you ..

@gettalong

This comment has been minimized.

Owner

gettalong commented Apr 20, 2013

Is now fixed.

@gettalong gettalong closed this Apr 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment