Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviations don't work in footnotes #440

Closed
thomasleese opened this issue Jun 30, 2017 · 2 comments
Closed

Abbreviations don't work in footnotes #440

thomasleese opened this issue Jun 30, 2017 · 2 comments
Assignees
Labels
bug

Comments

@thomasleese
Copy link

@thomasleese thomasleese commented Jun 30, 2017

It looks like abbreviations don't work in footnotes, with the following Markdown input I would expect to see an abbr tag in both the paragraph at the beginning and then in the footnote paragraph as well, but it doesn't appear in the footnote.

Input:

There is a TXT file here. [^1]

*[TXT]: Text File

[^1]: A TXT file.

Output:

<p>There is a <abbr title="Text File">TXT</abbr> file here. <sup id="fnref:1"><a href="#fn:1" class="footnote">1</a></sup></p>

<div class="footnotes">
  <ol>
    <li id="fn:1">
      <p>A TXT file.&nbsp;<a href="#fnref:1" class="reversefootnote">&#8617;</a></p>
    </li>
  </ol>
</div>
@gettalong gettalong self-assigned this Aug 26, 2017
@gettalong gettalong added the bug label Aug 26, 2017
@gettalong
Copy link
Owner

@gettalong gettalong commented Aug 26, 2017

Thanks for reporting - it certainly seems that abbreviation substitution should also be done in the footnotes.

Will fix that for the next release.

@gettalong
Copy link
Owner

@gettalong gettalong commented Aug 27, 2017

Done.

@gettalong gettalong closed this Aug 27, 2017
gettalong added a commit that referenced this issue Aug 27, 2017
rubenarakelyan added a commit to alphagov/govspeak that referenced this issue Oct 27, 2017
Fixes gettalong/kramdown#440 amongst other issues.
rubenarakelyan added a commit to alphagov/whitehall that referenced this issue Oct 27, 2017
rubenarakelyan added a commit to alphagov/whitehall that referenced this issue Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.