Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect underscore handling after --- for em-dash #624

Closed
codingthat opened this issue Sep 3, 2019 · 5 comments
Closed

Incorrect underscore handling after --- for em-dash #624

codingthat opened this issue Sep 3, 2019 · 5 comments
Assignees
Labels

Comments

@codingthat
Copy link

@codingthat codingthat commented Sep 3, 2019

An underscore-wrapped phrase immediately after a --- renders plainly instead of in italics.

E.g. it---by design---_cannot have side-effects_. renders like this:

image

But if you replace the latter --- with —, it works as intended.

So it---by design—_cannot have side-effects_. renders like this:

image

@gettalong gettalong self-assigned this Sep 5, 2019
@gettalong gettalong added the bug label Sep 5, 2019
@gettalong
Copy link
Owner

@gettalong gettalong commented Sep 5, 2019

Thanks for reporting this bug!

@ashmaroli
Copy link
Contributor

@ashmaroli ashmaroli commented Sep 16, 2019

@codingthat This should resolve by inserting spaces around the underscores:

it---by design--- _cannot have side-effects_.

@codingthat
Copy link
Author

@codingthat codingthat commented Sep 16, 2019

@ashmaroli Thanks, but not quite: That adds an undesired space between the latter em-dash and the word following it:

image

As you can see, this is different from the — workaround.

@codingthat
Copy link
Author

@codingthat codingthat commented Sep 17, 2019

Thanks @ashmaroli ! =)

@gettalong
Copy link
Owner

@gettalong gettalong commented Apr 16, 2020

@codingthat I have merged the pull request by @ashmaroli, so I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants