Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid IDs #658

Closed
ioquatix opened this issue Apr 30, 2020 · 5 comments
Closed

Valid IDs #658

ioquatix opened this issue Apr 30, 2020 · 5 comments
Assignees

Comments

@ioquatix
Copy link

@ioquatix ioquatix commented Apr 30, 2020

Hello.

HTML5 allows any character to be an ID.

So:

# Thing {#Bake-Types-self.Any}

should be valid.

@gettalong gettalong self-assigned this Apr 30, 2020
@gettalong
Copy link
Owner

@gettalong gettalong commented Apr 30, 2020

If we change this, I would make the ID XML-compatible so that the XML syntax of HTML5 is also supported - what do you think?

@ioquatix
Copy link
Author

@ioquatix ioquatix commented Apr 30, 2020

I think that's fine.

What's the implications of making it XML-compatible? I couldn't tell from the linked documentation. My understanding HTML5 basically allows any character. I assume except #?

@gettalong
Copy link
Owner

@gettalong gettalong commented May 3, 2020

Yes, HTML5 allows any character. However, there is also an XML syntax version of HTML5 (formerly known as XHTML) which might have a problem with that (didn't find anything on that, though).

The XML syntax has a special ID type with certain allowed values. I have changed kramdown to allow all characters that are also allowed for this ID type. See https://www.w3.org/TR/xml/#id and https://www.w3.org/TR/xml/#NT-Name.

@gettalong
Copy link
Owner

@gettalong gettalong commented May 3, 2020

Implemented in 90954bc

@ioquatix
Copy link
Author

@ioquatix ioquatix commented May 3, 2020

Great, thanks for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants