Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded strikethrough syntax to GitHub Flavored Markdown parser #184
Conversation
diegobg
added some commits
Nov 15, 2014
This comment has been minimized.
This comment has been minimized.
|
Does the code work correctly for the following case: I.e. what happens to the extra tilde? |
This comment has been minimized.
This comment has been minimized.
|
Lines 36 and 40 in gfm.rb are modified for whitespace only, please revert this. |
This comment has been minimized.
This comment has been minimized.
|
One more thing: There is no syntax description for the strikethrough syntax on Github, so please test on github some more variations and add tests for them - thanks! Otherwise it is looking good! |
gettalong
self-assigned this
Feb 3, 2015
This comment has been minimized.
This comment has been minimized.
|
Please fix the problems and I will re-open. |
gettalong
closed this
Feb 28, 2015
This comment has been minimized.
This comment has been minimized.
tkrotoff
commented
Mar 30, 2015
|
+1 for this feature |
This comment has been minimized.
This comment has been minimized.
CGarces
commented
Feb 1, 2016
|
Is strikethrough supported? I have done a sample page with the issue. |
CGarces
referenced this pull request
Feb 2, 2016
Closed
strikethrough doesn't work for GFM parser #304
parkr
referenced this pull request
Feb 8, 2016
Closed
Added strikethrough syntax to GitHub Flavored Markdown parser #307
pushed a commit
that referenced
this pull request
Feb 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
diegobg commentedNov 16, 2014
GitHub Flavored Markdown supports strikethrough text according to GitHub Help - GitHub Flavored Markdown but the GFM parser included with kramdown doesn't support it.
I've added strikethrough support to the GFM parser: when it encounters text delimited by two or more tildes, it creates a <del> HTML element that contains the text. This doesn't affect the standard kramdown parser.