New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added strikethrough syntax to GitHub Flavored Markdown parser #184

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@diegobg
Contributor

diegobg commented Nov 16, 2014

GitHub Flavored Markdown supports strikethrough text according to GitHub Help - GitHub Flavored Markdown but the GFM parser included with kramdown doesn't support it.

I've added strikethrough support to the GFM parser: when it encounters text delimited by two or more tildes, it creates a <del> HTML element that contains the text. This doesn't affect the standard kramdown parser.

@gettalong

This comment has been minimized.

Owner

gettalong commented Dec 6, 2014

Does the code work correctly for the following case:

This ~~is not~~~ possible.

I.e. what happens to the extra tilde?

@gettalong

This comment has been minimized.

Owner

gettalong commented Dec 6, 2014

Lines 36 and 40 in gfm.rb are modified for whitespace only, please revert this.

@gettalong

This comment has been minimized.

Owner

gettalong commented Dec 6, 2014

One more thing: There is no syntax description for the strikethrough syntax on Github, so please test on github some more variations and add tests for them - thanks!

Otherwise it is looking good!

@gettalong gettalong self-assigned this Feb 3, 2015

@gettalong

This comment has been minimized.

Owner

gettalong commented Feb 28, 2015

Please fix the problems and I will re-open.

@gettalong gettalong closed this Feb 28, 2015

@tkrotoff

This comment has been minimized.

tkrotoff commented Mar 30, 2015

+1 for this feature

@CGarces

This comment has been minimized.

CGarces commented Feb 1, 2016

Is strikethrough supported?
After the migration of github pages to kramdown I have lost my formatting

~~This~~ no longer works

I have done a sample page with the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment