Added strikethrough syntax to GitHub Flavored Markdown parser #184
Conversation
|
Does the code work correctly for the following case: I.e. what happens to the extra tilde? |
|
Lines 36 and 40 in gfm.rb are modified for whitespace only, please revert this. |
|
One more thing: There is no syntax description for the strikethrough syntax on Github, so please test on github some more variations and add tests for them - thanks! Otherwise it is looking good! |
|
Please fix the problems and I will re-open. |
|
+1 for this feature |
|
Is strikethrough supported? I have done a sample page with the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
GitHub Flavored Markdown supports strikethrough text according to GitHub Help - GitHub Flavored Markdown but the GFM parser included with kramdown doesn't support it.
I've added strikethrough support to the GFM parser: when it encounters text delimited by two or more tildes, it creates a <del> HTML element that contains the text. This doesn't affect the standard kramdown parser.