Skip to content

/ kramdown

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow toc_levels option to be of type Range #210

Closed
wants to merge 1 commit into from
Closed

allow toc_levels option to be of type Range #210

wants to merge 1 commit into from

Conversation

@jkraemer
Copy link
Contributor

@jkraemer jkraemer commented Jan 18, 2015

This is more or less cosmetics but I just stumbled across this - the docs are talking of 'range syntax' but passing an actual Range for the :toc_levels option didn't work.
@gettalong gettalong self-assigned this Jan 21, 2015
@gettalong
Copy link
Owner

@gettalong gettalong commented Jan 21, 2015

Thanks, this is a good idea.

However, the values of the array would need to be converted to integers in case the range isn't an integer range (see the array case). Please update your pull request in this regard.
@jkraemer
allow toc_levels option to be of type Range
Loading status checks…
d3a8fbc
@jkraemer jkraemer force-pushed the jkraemer:toc_levels_range branch from ebcbb23 to d3a8fbc Jan 21, 2015
@jkraemer
Copy link
Contributor Author

@jkraemer jkraemer commented Jan 21, 2015

updated!
@gettalong
Copy link
Owner

@gettalong gettalong commented Feb 5, 2015

Thank you - I have cherry-picked your commit!
@gettalong gettalong closed this Feb 5, 2015
@Stargator Stargator mentioned this pull request Jul 31, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gettalong gettalong

Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jkraemer @gettalong