New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language name with dash #246
Conversation
|
Fixed. But now some coderay tests are failing. Any idea how to fix that or is there another |
Ok. Now I understand your test-setup better. I added an options-file as well. Should I add a test for coderay as well? |
42 | ||
end | ||
~~~ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only add an example that uses a valid, real world language. Otherwise people might think that ruby-trunk
is some kind of Ruby based language.
Personally, I would not add any example because we never explicitly state the syntax requirements for the language. Also if a user wants to highlight a programming language that contains a dash he will just use it in the fenced code blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Thanks for everything and your patience! The changes are now in master. |
Wonderful. 😄 Thanks a lot. Any plans for a new release? |
Probably end of this week. |
👍 |
@gettalong
A new one for #244. This line might be worth to mention. Without the addition
latex
is not able to compile the document. If you've got a better idea where I should place the code, I'm open for suggestions.