Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upLanguage name with dash #246
Conversation
added some commits
Apr 19, 2015
gettalong
self-assigned this
Apr 20, 2015
gettalong
added
the
enhancement
label
Apr 20, 2015
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
Fixed. But now some coderay tests are failing. Any idea how to fix that or is there another |
This comment has been minimized.
This comment has been minimized.
|
Ok. Now I understand your test-setup better. I added an options-file as well. Should I add a test for coderay as well? |
gettalong
reviewed
Apr 20, 2015
| 42 | ||
| end | ||
| ~~~ | ||
This comment has been minimized.
This comment has been minimized.
gettalong
Apr 20, 2015
Owner
Please only add an example that uses a valid, real world language. Otherwise people might think that ruby-trunk is some kind of Ruby based language.
Personally, I would not add any example because we never explicitly state the syntax requirements for the language. Also if a user wants to highlight a programming language that contains a dash he will just use it in the fenced code blocks.
This comment has been minimized.
This comment has been minimized.
gettalong
reviewed
Apr 20, 2015
| @@ -27,7 +27,7 @@ def self.call(converter, text, lang, type, _unused_opts) | ||
| if type == :span && lang | ||
| ::CodeRay.scan(text, lang.to_sym).html(options(converter, :span)).chomp | ||
| elsif type == :block && (lang || options(converter, :default_lang)) | ||
| lang = (lang || options(converter, :default_lang)).to_sym | ||
| lang = (lang || options(converter, :default_lang)).to_s.gsub(/-/, '_').sub(/language_/, 'language-').to_sym | ||
| ::CodeRay.scan(text, lang).html(options(converter, :block)).chomp << "\n" |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gettalong
reviewed
Apr 20, 2015
| 42 | ||
| end | ||
| ~~~ | ||
This comment has been minimized.
This comment has been minimized.
gettalong
Apr 20, 2015
Owner
Why all the tests below? They don't make sense for this feature enhancement.
This comment has been minimized.
This comment has been minimized.
maxmeyer
Apr 20, 2015
Contributor
To make sure, that a language with a dash behaves the same like a language without a dash
This comment has been minimized.
This comment has been minimized.
gettalong
reviewed
Apr 20, 2015
| @@ -0,0 +1,2 @@ | ||
| :enable_coderay: false | ||
This comment has been minimized.
This comment has been minimized.
gettalong
Apr 20, 2015
Owner
I think there shouldn't be any need for this file anymore since you modify the language name for coderay to use underscores instead of dashes.
This comment has been minimized.
This comment has been minimized.
maxmeyer
Apr 20, 2015
Contributor
I added this because the HTML generated without the coderay converter is much simpler and is the same like for the existing tests.
This comment has been minimized.
This comment has been minimized.
|
Thanks for everything and your patience! The changes are now in master. |
gettalong
closed this
Apr 20, 2015
gettalong
referenced this pull request
Apr 20, 2015
Closed
Support "-" (dash) in name of code block lang #244
This comment has been minimized.
This comment has been minimized.
|
Wonderful. |
This comment has been minimized.
This comment has been minimized.
|
Probably end of this week. |
This comment has been minimized.
This comment has been minimized.
|
|
maxmeyer commentedApr 19, 2015
@gettalong
A new one for #244. This line might be worth to mention. Without the addition
latexis not able to compile the document. If you've got a better idea where I should place the code, I'm open for suggestions.