Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language name with dash #246

Closed
wants to merge 2 commits into from
Closed

Language name with dash #246

wants to merge 2 commits into from

Conversation

maxmeyer
Copy link
Contributor

@gettalong

A new one for #244. This line might be worth to mention. Without the addition latex is not able to compile the document. If you've got a better idea where I should place the code, I'm open for suggestions.

@gettalong
Copy link
Owner

  • The regexp should be \w[\w-]* so that it does not start with a dash.
  • Please remove the tmp/ directory from .gitignore.
  • You need to add the test to the EXCLUDE_LATEX_FILES list to avoid running the conversion instead of the added code.

@maxmeyer
Copy link
Contributor Author

Fixed. But now some coderay tests are failing. Any idea how to fix that or is there another EXCLUDE_ I can use for this?

@maxmeyer
Copy link
Contributor Author

Ok. Now I understand your test-setup better. I added an options-file as well. Should I add a test for coderay as well?

42
end
~~~


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only add an example that uses a valid, real world language. Otherwise people might think that ruby-trunk is some kind of Ruby based language.

Personally, I would not add any example because we never explicitly state the syntax requirements for the language. Also if a user wants to highlight a programming language that contains a dash he will just use it in the fenced code blocks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@gettalong
Copy link
Owner

Thanks for everything and your patience! The changes are now in master.

@maxmeyer
Copy link
Contributor Author

Wonderful. 😄 Thanks a lot. Any plans for a new release?

@gettalong
Copy link
Owner

Probably end of this week.

@maxmeyer
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants