New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to remove formatter from options #356

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@le0pard
Contributor

le0pard commented Jul 21, 2016

If you remove formatter for options, this leave next code without this formatter. Example without fix:

no fix

With fix:

fix

@le0pard

This comment has been minimized.

Contributor

le0pard commented Jul 21, 2016

Looks like rouge 2.0 broke tests

@gettalong gettalong self-assigned this Jul 21, 2016

@gettalong

This comment has been minimized.

Owner

gettalong commented Jul 21, 2016

Please provide the kramdown sources and their HTML output for the failing case, images aren't really useful.

No need to remove formatter from options
If you remove formatter for options, this leave next code without this formatter
@le0pard

This comment has been minimized.

Contributor

le0pard commented Jul 22, 2016

I tried as I can, but for ruby 1.8 need more (not sure, why it supported) works. Also test env unstable (npm install network issue, rouge gem version 1 and 2)

@le0pard

This comment has been minimized.

Contributor

le0pard commented Jul 26, 2016

@gettalong should I do something else?

@gettalong

This comment has been minimized.

Owner

gettalong commented Jul 26, 2016

Please provide the kramdown sources and their HTML output for the failing case here in the issue , images aren't really useful.

@le0pard

This comment has been minimized.

Contributor

le0pard commented Jul 26, 2016

I just add this as test case. Or it is not enough?

@gettalong

This comment has been minimized.

Owner

gettalong commented Jul 26, 2016

kramdown test cases are plain text files with accompanying HTML and/or other output files, see test/testcases/.

It would be easier if you just provide the plain text source as well as the current HTML output and the wanted HTML output directly here so that one doesn't have to extract them from the code.

@le0pard

This comment has been minimized.

Contributor

le0pard commented Jul 26, 2016

@gettalong looks like done. Please, check.

@gettalong

This comment has been minimized.

Owner

gettalong commented Jul 26, 2016

Thanks, I get the problem now (it's really too hot in the city to think straight...)!

@gettalong gettalong added the bug label Aug 7, 2016

@gettalong

This comment has been minimized.

Owner

gettalong commented Aug 7, 2016

I have updated the test_files.rb script to work with Ruby 1.8.7, locally works fine.

Change will be in the next release.

@gettalong gettalong closed this Aug 7, 2016

@le0pard

This comment has been minimized.

Contributor

le0pard commented Aug 7, 2016

@gettalong thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment