Skip to content

No need to remove formatter from options - #356

Closed
le0pard wants to merge 2 commits into
gettalong:masterfrom
le0pard:patch-2
Closed

No need to remove formatter from options#356
le0pard wants to merge 2 commits into
gettalong:masterfrom
le0pard:patch-2

Conversation

@le0pard

@le0pard le0pard commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

If you remove formatter for options, this leave next code without this formatter. Example without fix:

no fix

With fix:

fix

@le0pard

le0pard commented Jul 21, 2016

Copy link
Copy Markdown
Contributor Author

Looks like rouge 2.0 broke tests

@gettalong gettalong self-assigned this Jul 21, 2016
@gettalong

gettalong commented Jul 21, 2016

Copy link
Copy Markdown
Owner

Please provide the kramdown sources and their HTML output for the failing case, images aren't really useful.

If you remove formatter for options, this leave next code without this formatter
@le0pard

le0pard commented Jul 22, 2016

Copy link
Copy Markdown
Contributor Author

I tried as I can, but for ruby 1.8 need more (not sure, why it supported) works. Also test env unstable (npm install network issue, rouge gem version 1 and 2)

@le0pard

le0pard commented Jul 26, 2016

Copy link
Copy Markdown
Contributor Author

@gettalong should I do something else?

@gettalong

Copy link
Copy Markdown
Owner

Please provide the kramdown sources and their HTML output for the failing case here in the issue , images aren't really useful.

@le0pard

le0pard commented Jul 26, 2016

Copy link
Copy Markdown
Contributor Author

I just add this as test case. Or it is not enough?

@gettalong

Copy link
Copy Markdown
Owner

kramdown test cases are plain text files with accompanying HTML and/or other output files, see test/testcases/.

It would be easier if you just provide the plain text source as well as the current HTML output and the wanted HTML output directly here so that one doesn't have to extract them from the code.

@le0pard

le0pard commented Jul 26, 2016

Copy link
Copy Markdown
Contributor Author

@gettalong looks like done. Please, check.

@gettalong

Copy link
Copy Markdown
Owner

Thanks, I get the problem now (it's really too hot in the city to think straight...)!

@gettalong gettalong added the bug label Aug 7, 2016
@gettalong

Copy link
Copy Markdown
Owner

I have updated the test_files.rb script to work with Ruby 1.8.7, locally works fine.

Change will be in the next release.

@gettalong gettalong closed this Aug 7, 2016
@le0pard

le0pard commented Aug 7, 2016

Copy link
Copy Markdown
Contributor Author

@gettalong thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants