Skip to content

GFM compatibility for list/blockquote/fenced codeblock and atx header - #358

Closed
tsl0922 wants to merge 1 commit into
gettalong:masterfrom
tsl0922:gfm-compatibility
Closed

tsl0922 wants to merge 1 commit into
gettalong:masterfrom
tsl0922:gfm-compatibility

Conversation

@tsl0922

@tsl0922 tsl0922 commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

This PR fixes the issues described in #336 #359:

A
  - b

blockquote
> text

header
# text

codeblock fenced
```
puts hello world
```

kramdown result:

<p>A<br />
  - b</p>

<p>blockquote<br />
&gt; text</p>

<p>header<br />
# text</p>

<p>codeblock fenced<br />
<code>
puts hello world
</code></p>

github result:

A

  • b

blockquote

text

header

text

codeblock fenced

puts hello world

NOTES:

  • This PR breaks an existing test: test/testcases/span/math/normal.text, which I think can be safely disabled for GFM.
  • Fixes travis-ci failure due to rouge 2.0 compatibility issue Rouge 2.0 compatibility #350

@tsl0922
tsl0922 force-pushed the gfm-compatibility branch from b584232 to 8b846f8 Compare July 28, 2016 10:26
@tsl0922
tsl0922 force-pushed the gfm-compatibility branch from 8b846f8 to 29e245b Compare August 5, 2016 01:47
@tsl0922 tsl0922 changed the title GFM compatibility for list/blockquote and atx header GFM compatibility for list/blockquote/fenced codeblock and atx header Aug 5, 2016
@gettalong gettalong self-assigned this Aug 7, 2016
@gettalong gettalong added the bug label Aug 7, 2016
@gettalong

Copy link
Copy Markdown
Owner

Thanks for the pull request! I have cherry-picked your commit, this will be in the next release.

@MattiSG

MattiSG commented Aug 8, 2016

Copy link
Copy Markdown

🎊 Thanks to both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants