Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFM compatibility for list/blockquote/fenced codeblock and atx header #358

Closed
wants to merge 1 commit into from

Conversation

tsl0922
Copy link
Contributor

@tsl0922 tsl0922 commented Jul 28, 2016

This PR fixes the issues described in #336 #359:

A
  - b

blockquote
> text

header
# text

codeblock fenced
```
puts hello world
```

kramdown result:

<p>A<br />
  - b</p>

<p>blockquote<br />
&gt; text</p>

<p>header<br />
# text</p>

<p>codeblock fenced<br />
<code>
puts hello world
</code></p>

github result:

A

  • b

blockquote

text

header

text

codeblock fenced

puts hello world

NOTES:

  • This PR breaks an existing test: test/testcases/span/math/normal.text, which I think can be safely disabled for GFM.
  • Fixes travis-ci failure due to rouge 2.0 compatibility issue Rouge 2.0 compatibility #350

@tsl0922 tsl0922 changed the title GFM compatibility for list/blockquote and atx header GFM compatibility for list/blockquote/fenced codeblock and atx header Aug 5, 2016
@gettalong gettalong self-assigned this Aug 7, 2016
@gettalong gettalong added the bug label Aug 7, 2016
@gettalong
Copy link
Owner

Thanks for the pull request! I have cherry-picked your commit, this will be in the next release.

@MattiSG
Copy link

MattiSG commented Aug 8, 2016

🎊 Thanks to both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants